Fix operation trait not applied correctly in Foundations.Operation #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
timotheeguerin
changed the title
|
All changed packages have been documented. |
timotheeguerin
commented
Mar 11, 2024
| TraitLocation.ApiVersionParameter | ||
| >, | ||
| ...TraitProperties<VersionParameterTrait<ApiVersionParameter>, TraitLocation.ApiVersionParameter>, | ||
| ...TraitProperties<Traits, TraitLocation.Parameters>, |
There was a problem hiding this comment.
Ok so this was done on purpose because the addition of the trait parameters is done earlier in most cases.
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/399/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/399/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix microsoft/typespec#2938
Problem seems to be that we tried to applied the request trait using the ApiVersion location so it wouldn't include trait that are meant to be included as request parameters