[tcgc] fix string kinds to just use what is coming from tsp #255
Conversation
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar and
joheredi
as code owners
|
All changed packages have been documented! |
iscai-msft
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/255/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/255/ |
| - "@azure-tools/typespec-client-generator-core" | ||
| --- | ||
|
|
||
| allows us to generate arm packages |
There was a problem hiding this comment.
not sure this will make much sense to what is fixed here to someone looking at the changelog
| @@ -109,21 +109,15 @@ function addFormatInfo( | |||
| case "uuid": | |||
| case "password": | |||
| case "etag": | |||
| case "arm-id": | |||
There was a problem hiding this comment.
I thought we agreed that @format was not going to be used
There was a problem hiding this comment.
oh you're right, these are all actual scalar types right?
There was a problem hiding this comment.
there should be, password is just @secret, if there is some missing that are needed right now then we should look into adding them as soon as possible.
There was a problem hiding this comment.
ok made them actual scalar kinds. to clarify, we should never look at the @format decorator later down the line right?
| @@ -195,12 +189,20 @@ function getScalarKind(scalar: Scalar): SdkBuiltInKinds { | |||
| case "decimal": | |||
| case "plainDate": | |||
| case "plainTime": | |||
| case "arm-id": | |||
There was a problem hiding this comment.
Sorry a lot of those are not built-in the compiler, they are in azure-core so you have to check the right namespace
No description provided.