Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y bugfix] reaction item aria narration #4635

Merged
merged 4 commits into from
May 21, 2024
Merged

[A11y bugfix] reaction item aria narration #4635

merged 4 commits into from
May 21, 2024

Conversation

dmceachernmsft
Copy link
Member

What

Add aria labels to each of the reaction items

Why

Allows for the different narrators to read out each name

https://skype.visualstudio.com/SPOOL/_workitems/edit/3674307

How Tested

Validated locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners May 17, 2024 23:28
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-iqvkszajic.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

Calling bundle size is increased❗.

  • Current size: 4845659
  • Base size: 4845640
  • Diff size: 19

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

Chat bundle size is not changed.

  • Current size: 2056542
  • Base size: 2056542
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

CallWithChat bundle size is increased❗.

  • Current size: 6170293
  • Base size: 6170274
  • Diff size: 19

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25829 / 40006
64.56%		 25829 / 40006
64.56%		 710 / 1255
56.57%		 2079 / 3266
63.65%
Current 25832 / 40006
64.57%		 25832 / 40006
64.57%		 710 / 1255
56.57%		 2081 / 3267
63.69%
Diff 3 / 0
0.01%		 3 / 0
0.01%		 0 / 0
0%		 2 / 1
0.04%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50264 / 80229
62.65%		 50264 / 80229
62.65%		 1028 / 2278
45.12%		 2945 / 4825
61.03%
Current 50264 / 80230
62.64%		 50264 / 80230
62.64%		 1028 / 2278
45.12%		 2964 / 4836
61.29%
Diff 0 / 1
-0.01%		 0 / 1
-0.01%		 0 / 0
0%		 19 / 11
0.26%

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) May 21, 2024 17:28
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-olvtfajwzy.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit c98610a into main May 21, 2024
41 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/reaction-a11y-naming branch May 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@mgamis-msft mgamis-msft

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmceachernmsft @mgamis-msft @edwardlee-msft