Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11Y] Status icon should not be keyboard tab navigable #4634

Merged
merged 5 commits into from
May 21, 2024

Conversation

palatter
Copy link
Member

Status icon should not be keyboard tab navigable, it should only be navigable by voiceover.

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

github-actions bot commented May 17, 2024

Calling bundle size is not changed.

  • Current size: 4845659
  • Base size: 4845659
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 17, 2024

CallWithChat bundle size is decreased✅.

  • Current size: 6170285
  • Base size: 6170293
  • Diff size: -8

Copy link
Contributor

github-actions bot commented May 17, 2024

Chat bundle size is decreased✅.

  • Current size: 2056534
  • Base size: 2056542
  • Diff size: -8

@palatter palatter changed the title [DRAFT] [A11Y] Status icon should not be keyboard tab navigable [A11Y] Status icon should not be keyboard tab navigable May 17, 2024
@palatter palatter marked this pull request as ready for review May 17, 2024 22:05
@palatter palatter requested review from a team as code owners May 17, 2024 22:05
Copy link
Contributor

Copy link
Contributor

github-actions bot commented May 17, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25773 / 40006
64.42%
25773 / 40006
64.42%
710 / 1255
56.57%
2067 / 3253
63.54%
Current 25774 / 40004
64.42%
25774 / 40004
64.42%
710 / 1255
56.57%
2049 / 3243
63.18%
Diff 1 / -2
0%
1 / -2
0%
0 / 0
0%
-18 / -10
-0.36%

Copy link
Contributor

github-actions bot commented May 17, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50190 / 80230
62.55%
50190 / 80230
62.55%
1028 / 2278
45.12%
2910 / 4796
60.67%
Current 50213 / 80227
62.58%
50213 / 80227
62.58%
1028 / 2278
45.12%
2923 / 4816
60.69%
Diff 23 / -3
0.03%
23 / -3
0.03%
0 / 0
0%
13 / 20
0.02%

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@palatter palatter merged commit 50a6335 into main May 21, 2024
41 checks passed
@palatter palatter deleted the palatter/send-status-a11y-issue branch May 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants