Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chat] Updated Storybook for File Sharing GA release #4629

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Chat] Updated Storybook for File Sharing GA release #4629

wants to merge 5 commits into from

Conversation

jpeng-ms
Copy link
Member

@jpeng-ms jpeng-ms commented May 16, 2024 •
edited

What

Do not merge before beta release cut is made

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@jpeng-ms
Update MessageThread.stories.tsx
d18f46f 
Signed-off-by: John <109105353+jpeng-ms@users.noreply.github.com>
@jpeng-ms
Update MessageThread.mdx
e19d490 
Signed-off-by: John <109105353+jpeng-ms@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-jsgzenwipf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

Calling bundle size is not changed.

  • Current size: 4852189
  • Base size: 4852189
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

CallWithChat bundle size is not changed.

  • Current size: 6176699
  • Base size: 6176699
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

Chat bundle size is not changed.

  • Current size: 2061823
  • Base size: 2061823
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25996 / 40676
63.9%		 25996 / 40676
63.9%		 710 / 1268
55.99%		 2039 / 3245
62.83%
Current 25999 / 40676
63.91%		 25999 / 40676
63.91%		 710 / 1268
55.99%		 2071 / 3262
63.48%
Diff 3 / 0
0.01%		 3 / 0
0.01%		 0 / 0
0%		 32 / 17
0.65%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50253 / 80891
62.12%		 50253 / 80891
62.12%		 1028 / 2283
45.02%		 2916 / 4810
60.62%
Current 50253 / 80891
62.12%		 50253 / 80891
62.12%		 1028 / 2283
45.02%		 2957 / 4832
61.19%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 41 / 22
0.57%

@jimchou-dev jimchou-dev marked this pull request as ready for review May 27, 2024 17:48
@jimchou-dev jimchou-dev requested review from a team as code owners May 27, 2024 17:48
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-sgamigtasi.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-fzbvyjkoyd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-bwggbplxdn.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@palatter palatter palatter approved these changes

@jimchou-dev jimchou-dev jimchou-dev approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JoshuaLai JoshuaLai

@palatter palatter

@AmyL219 AmyL219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jpeng-ms @emlynmac @palatter @jimchou-dev @Leah-Xia-Microsoft @JoshuaLai @AmyL219