Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y bugfix] call control aria updates #4624

Merged
merged 7 commits into from
May 27, 2024

Conversation

dmceachernmsft
Copy link
Member

What

Updates the order of priority for the aria label on the control bar buttons

Why

We want to prioritize the visual label on the button so that users who are using voice controls can more easily control the following buttons

  • raise hand
  • react
  • screenshare

https://skype.visualstudio.com/SPOOL/_workitems/edit/3674604

How Tested

Validated locally with voice over

Copy link
Contributor

github-actions bot commented May 16, 2024

Chat bundle size is not changed.

  • Current size: 2061900
  • Base size: 2061900
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 16, 2024

Calling bundle size is not changed.

  • Current size: 4851643
  • Base size: 4851643
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 16, 2024

CallWithChat bundle size is not changed.

  • Current size: 6176230
  • Base size: 6176230
  • Diff size: 0

Copy link
Contributor

 into dmceachernmsft/call-control-aria-updates
Copy link
Contributor

 into dmceachernmsft/call-control-aria-updates
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

github-actions bot commented May 16, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26055 / 40680
64.04%
26055 / 40680
64.04%
710 / 1268
55.99%
2064 / 3265
63.21%
Current 26055 / 40680
64.04%
26055 / 40680
64.04%
710 / 1268
55.99%
2071 / 3269
63.35%
Diff 0 / 0
0%
0 / 0
0%
0 / 0
0%
7 / 4
0.14%

Copy link
Contributor

github-actions bot commented May 16, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50232 / 80862
62.12%
50232 / 80862
62.12%
1028 / 2283
45.02%
2909 / 4801
60.59%
Current 50260 / 80862
62.15%
50260 / 80862
62.15%
1028 / 2283
45.02%
2954 / 4829
61.17%
Diff 28 / 0
0.03%
28 / 0
0.03%
0 / 0
0%
45 / 28
0.58%

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) May 27, 2024 20:00
Copy link
Contributor

Copy link
Contributor

@dmceachernmsft dmceachernmsft merged commit 320ba57 into main May 27, 2024
41 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/call-control-aria-updates branch May 27, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants