-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y bugfix] call control aria updates #4624
Merged
dmceachernmsft
merged 7 commits into
main
from
dmceachernmsft/call-control-aria-updates
May 27, 2024
Merged
[A11y bugfix] call control aria updates #4624
dmceachernmsft
merged 7 commits into
main
from
dmceachernmsft/call-control-aria-updates
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmceachernmsft
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
May 16, 2024 17:22
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
prabhjot-msft
approved these changes
May 16, 2024
edwardlee-msft
approved these changes
May 16, 2024
JamesBurnside
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the order of priority for the aria label on the control bar buttons
Why
We want to prioritize the visual label on the button so that users who are using voice controls can more easily control the following buttons
https://skype.visualstudio.com/SPOOL/_workitems/edit/3674604
How Tested
Validated locally with voice over