Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint rule to disallow non-null-assertion #4613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PorterNan
Copy link
Member

What

Add eslint rule to disallow non-null-assertion

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 4892088
  • Base size: 4892088
  • Diff size: 0

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 6344461
  • Base size: 6344461
  • Diff size: 0

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 2180378
  • Base size: 2180378
  • Diff size: 0

Copy link
Member

@JamesBurnside JamesBurnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this PR! Will wait for lint fixes from new rule to be fixed before approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants