Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase participant item muted icon size #4610

Merged
merged 8 commits into from
May 23, 2024
Merged

Increase participant item muted icon size #4610

merged 8 commits into from
May 23, 2024

Conversation

mgamis-msft
Copy link
Contributor

What

Increase participant item muted icon size

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3685170

How Tested

Can see icon size change in updated snapshots

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@mgamis-msft mgamis-msft requested review from a team as code owners May 15, 2024 07:07
@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label May 15, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-hcbsnwujez.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Chat bundle size is decreased✅.

  • Current size: 2057143
  • Base size: 2057173
  • Diff size: -30

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

CallWithChat bundle size is decreased✅.

  • Current size: 6171008
  • Base size: 6171038
  • Diff size: -30

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Calling bundle size is decreased✅.

  • Current size: 4846417
  • Base size: 4846447
  • Diff size: -30

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-exkymicemt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-smarbjesnc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25775 / 40006
64.42%		 25775 / 40006
64.42%		 710 / 1255
56.57%		 2045 / 3239
63.13%
Current 25833 / 40006
64.57%		 25833 / 40006
64.57%		 710 / 1255
56.57%		 2069 / 3259
63.48%
Diff 58 / 0
0.15%		 58 / 0
0.15%		 0 / 0
0%		 24 / 20
0.35%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50180 / 80236
62.54%		 50180 / 80236
62.54%		 1028 / 2278
45.12%		 2930 / 4811
60.9%
Current 50207 / 80236
62.57%		 50207 / 80236
62.57%		 1028 / 2278
45.12%		 2937 / 4814
61%
Diff 27 / 0
0.03%		 27 / 0
0.03%		 0 / 0
0%		 7 / 3
0.1%

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-xjywnuejmv.chromatic.com/

@mgamis-msft mgamis-msft force-pushed the mgamis/fix-participant-item-muted-icon-size branch from 4002a21 to c74523e Compare May 22, 2024 21:35
@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label May 22, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-dgekrnusii.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-ncoyhirlld.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-pfwyciyiun.chromatic.com/

@mgamis-msft mgamis-msft enabled auto-merge (squash) May 23, 2024 23:26
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-ehpredgwfu.chromatic.com/

@mgamis-msft mgamis-msft merged commit 79c7405 into main May 23, 2024
41 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/fix-participant-item-muted-icon-size branch May 23, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhjot-msft prabhjot-msft prabhjot-msft approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@prabhjot-msft prabhjot-msft

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgamis-msft @prabhjot-msft @edwardlee-msft