Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local participant item to show menu icon when hovered and there are menu buttons #4609

Merged
merged 4 commits into from
May 23, 2024
Merged

Fix local participant item to show menu icon when hovered and there are menu buttons #4609

merged 4 commits into from
May 23, 2024

Conversation

mgamis-msft
Copy link
Contributor

@mgamis-msft mgamis-msft commented May 15, 2024 •
edited

What

Fix local participant item to show menu icon when hovered and there are menu buttons

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3726245

How Tested

Local calling sample:
https://github.com/Azure/communication-ui-library/assets/79475487/716d1d45-b2fc-47cb-a1a0-1791e9bd21f0
Local call with chat samples test:
https://github.com/Azure/communication-ui-library/assets/79475487/f5cffc70-c286-4b54-9ae5-9313d24410e1

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@mgamis-msft mgamis-msft requested review from a team as code owners May 15, 2024 07:06
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-lmdkdxccbr.chromatic.com/

@mgamis-msft mgamis-msft changed the title Fix local participant item to show menu icon Fix local participant item to show menu icon when hovered May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

CallWithChat bundle size is increased❗.

  • Current size: 6171038
  • Base size: 6171011
  • Diff size: 27

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Chat bundle size is increased❗.

  • Current size: 2057173
  • Base size: 2057146
  • Diff size: 27

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Calling bundle size is increased❗.

  • Current size: 4846447
  • Base size: 4846420
  • Diff size: 27

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25834 / 40006
64.57%		 25834 / 40006
64.57%		 710 / 1255
56.57%		 2080 / 3263
63.74%
Current 25775 / 40006
64.42%		 25775 / 40006
64.42%		 710 / 1255
56.57%		 2037 / 3234
62.98%
Diff -59 / 0
-0.15%		 -59 / 0
-0.15%		 0 / 0
0%		 -43 / -29
-0.76%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 50261 / 80236
62.64%		 50261 / 80236
62.64%		 1028 / 2278
45.12%		 2966 / 4835
61.34%
Current 50205 / 80236
62.57%		 50205 / 80236
62.57%		 1028 / 2278
45.12%		 2955 / 4823
61.26%
Diff -56 / 0
-0.07%		 -56 / 0
-0.07%		 0 / 0
0%		 -11 / -12
-0.08%

@mgamis-msft mgamis-msft changed the title Fix local participant item to show menu icon when hovered Fix local participant item to show menu icon when hovered and there are menu buttons May 22, 2024
@PorterNan
Copy link
Member

I thought we intentionally disable menu icon for local participant - what happens if people click on the icon?

@mgamis-msft mgamis-msft enabled auto-merge (squash) May 23, 2024 03:06
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-njxkowrcae.chromatic.com/

@mgamis-msft mgamis-msft merged commit 8482618 into main May 23, 2024
41 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/fix-local-participant-item-to-show-menu-icon branch May 23, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PorterNan PorterNan PorterNan approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@PorterNan PorterNan

@dmceachernmsft dmceachernmsft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgamis-msft @PorterNan @dmceachernmsft