Add meeting conference numbers info to stateful client #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzdor
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
Signed-off-by: Ruslan Zdor <99833343+rzdor@users.noreply.github.com>
CallWithChat bundle size is increased❗.
|
Chat bundle size is not changed.
|
Calling bundle size is increased❗.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
May 28, 2024
| info: callInfo | ||
| info: callInfo, | ||
| /* @conditional-compile-remove(teams-meeting-conference) */ | ||
| teamsMeetingConference: undefined |
There was a problem hiding this comment.
Is this defaulting to undefined in the case that there is no conference coordinates? like in the case that this is a ACS call?
There was a problem hiding this comment.
Yes, meeting conference will contain phone information and it is available only in meeting scenario
edwardlee-msft
approved these changes
May 28, 2024
rzdor
added
the
update_snapshots
github-actions
bot
removed
the
update_snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meeting conference numbers info will contain number and conference code to add ability to make pstn calls in Teams meetings.
This information could be found in this popup in Teams
