Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HMR in our samples #4567

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

JamesBurnside
Copy link
Member

What

Why

Support hot module reload in our samples (no more refreshing the page, rejoining the call etc. for small changes)

How Tested

Ran locally in codespaces and could hot reload isolated modules

HMR-cap.mp4

@JamesBurnside JamesBurnside added the do not need changelog Changes that does not affect the published package in any way do not need changelog entry label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Chat bundle size is not changed.

  • Current size: 2150696
  • Base size: 2150696
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 2, 2024

Calling bundle size is not changed.

  • Current size: 4888203
  • Base size: 4888203
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 2, 2024

CallWithChat bundle size is not changed.

  • Current size: 6282798
  • Base size: 6282798
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 2, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25359 / 39283
64.55%
25359 / 39283
64.55%
698 / 1230
56.74%
2025 / 3206
63.16%
Current 25305 / 39283
64.41%
25305 / 39283
64.41%
698 / 1230
56.74%
2027 / 3201
63.32%
Diff -54 / 0
-0.14%
-54 / 0
-0.14%
0 / 0
0%
2 / -5
0.16%

Copy link
Contributor

github-actions bot commented May 2, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49918 / 79373
62.89%
49918 / 79373
62.89%
1037 / 2301
45.06%
2924 / 4794
60.99%
Current 49851 / 79373
62.8%
49851 / 79373
62.8%
1037 / 2301
45.06%
2901 / 4776
60.74%
Diff -67 / 0
-0.09%
-67 / 0
-0.09%
0 / 0
0%
-23 / -18
-0.25%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant