Add context menu icon for removing participant #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgamis-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
Chat bundle size is increased❗.
|
Calling bundle size is increased❗.
|
CallWithChat bundle size is increased❗.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
mgamis-msft
added
the
update_snapshots
github-actions
bot
removed
the
update_snapshots
edwardlee-msft
approved these changes
May 6, 2024
mgamis-msft
force-pushed
the
mgamis/add-context-menu-icon-to-remove-participant
branch
from
fb346ff
to
1396851
Compare
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
mgamis-msft
added
the
update_snapshots
github-actions
bot
removed
the
update_snapshots
…ttps://github.com/Azure/communication-ui-library into mgamis/add-context-menu-icon-to-remove-participant
dmceachernmsft
approved these changes
May 16, 2024
| @@ -321,6 +321,10 @@ export const ParticipantList = (props: ParticipantListProps): JSX.Element => { | |||
| itemProps: { | |||
| styles: props.styles?.participantItemStyles?.participantSubMenuItemsStyles | |||
| }, | |||
| iconProps: { | |||
| iconName: 'ContextMenuRemoveParticipant', | |||
| styles: { root: { lineHeight: 0 } } | |||
There was a problem hiding this comment.
nit : I think there is a style that we have set you can import so there isn't a magic 0
mgamis-msft
deleted the
mgamis/add-context-menu-icon-to-remove-participant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add context menu icon for removing participant
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3687998
How Tested
Local Calling sample testing
Desktop:
Mobile:
Process & policy checklist
Is this a breaking change?