Support credential-less datastores in MoMo StoreUrl #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for model-monitoring-gsq-ci13 tests 13 ✅ 1h 11m 35s ⏱️ Results for commit 3552d86. ♻️ This comment has been updated with latest results. |
Test Results for model-monitoring-ci346 tests 331 ✅ 1h 10m 6s ⏱️ Results for commit 3552d86. ♻️ This comment has been updated with latest results. |
RichardLi1437
previously approved these changes
May 30, 2024
RichardLi1437
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to support reading and writing spark dataframe to mltable and vice versa using StoreUrl class.
For showing a helpful error message when the User has a credential-less datastore but we haven't submitted using Managed identity this is the before and after examples:
before: https://ml.azure.com/experiments/id/ee0dda29-a025-403b-9c91-81c818a5293b/runs/silly_loquat_cylcm5565v?wsid=/subscriptions/1aefdc5e-3a7c-4d71-a9f9-f5d3b03be19a/resourceGroups/momo-rampup-alanpo/providers/Microsoft.MachineLearningServices/workspaces/project-alantest-oai&tid=72f988bf-86f1-41af-91ab-2d7cd011db47#
after: https://ml.azure.com/runs/polite_cart_f2qfdp6p2g?wsid=/subscriptions/1aefdc5e-3a7c-4d71-a9f9-f5d3b03be19a/resourcegroups/momo-rampup-alanpo/workspaces/project-alantest-oai&tid=72f988bf-86f1-41af-91ab-2d7cd011db47#