Update validate_assets.py: Ignore .whl files in build context #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore python wheel files (.whl) when validating files in Env build context.
```python
Traceback (most recent call last):
File "/home/runner/work/azureml-assets/azureml-assets/scripts/azureml-assets/azureml/assets/validate_assets.py", line 1150, in <module>
success = validate_assets(input_dirs=input_dirs,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/azureml-assets/azureml-assets/scripts/azureml-assets/azureml/assets/validate_assets.py", line 1057, in validate_assets
error_count += validate_build_context(asset_config.extra_config_as_object())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/azureml-assets/azureml-assets/scripts/azureml-assets/azureml/assets/validate_assets.py", line 303, in validate_build_context
contents = f.read()
^^^^^^^^
File "<frozen codecs>", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbc in position 15: invalid start byte
```
Test Results for scripts-test62 tests 61 ✅ 6m 46s ⏱️ For more details on these failures, see this check. Results for commit 09c9f49. ♻️ This comment has been updated with latest results. |
vizhur
requested changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore python wheel files (.whl) when validating files in Env build context. Currently we try to read all files inside Env's build context. We need to commit .whl files for python packages that are not yet available on pypi. One such package is singularityrt: #2892
A failing GH Actions run for reference: https://github.com/Azure/azureml-assets/actions/runs/9065729716/job/24906950702?pr=2892