-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deesharma/connectedclusternewversion #29148
base: main
Are you sure you want to change the base?
Deesharma/connectedclusternewversion #29148
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
connectedClusters.json | 2024-06-01-preview(0643155) | 2024-01-01(main) |
connectedClusters.json | 2024-06-01-preview(0643155) | 2024-02-01-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 5 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-preview-2024-06-01 | package-preview-2024-06-01(0643155) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L867 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L871 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L883 |
||
Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L919 |
||
Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L926 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: oidcIssuer Url: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L577:35 ExampleUrl: preview/2024-06-01-preview/examples/GetClusterExample.json#L48:25 |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: oidcIssuer Url: Microsoft.Kubernetes/preview/2024-06-01-preview/connectedClusters.json#L577:35 ExampleUrl: preview/2024-06-01-preview/examples/GetClusterExample.json#L48:25 |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
….com/deeksha345/azure-rest-api-specs into deesharma/connectedclusternewversion
Adding example for agentState in getClusterExample
Update get cluster example with all the newly added properties to the cc swagger
For new API versions pl raise the first commit as an exact copy of the previous API version and the add actual changes in the next commit. This allows the reviewer to get a clear understanding of the changes being made in the new API version, In its current state, the PR is not reviewable. |
Also fix the basic parsing issues - https://github.com/Azure/azure-rest-api-specs/pull/29148/checks?check_run_id=25856205427 |
I have followed this guidance! The initial commit is an exact copy of api version 2024-02-01-preview |
I followed the link and see the following note "The following errors/warnings exist before current PR submission" |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.