-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new API version 2024-06-01-preview #29141
Merged
razvanbadea-msft
merged 5 commits into
Azure:main
from
revanthballa1188:revanth1188-redisenterprise-Microsoft.cache-2024-06-01-preview
May 22, 2024
Merged
Add new API version 2024-06-01-preview #29141
razvanbadea-msft
merged 5 commits into
Azure:main
from
revanthballa1188:revanth1188-redisenterprise-Microsoft.cache-2024-06-01-preview
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-03-01-preview to preview/2024-06-01-preview.
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
redisenterprise.json | 2024-06-01-preview(36e9155) | 2024-02-01(main) |
redisenterprise.json | 2024-06-01-preview(36e9155) | 2024-03-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-preview-2024-06 | package-preview-2024-06(36e9155) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L201 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:name. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L201 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L220 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L231 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L264 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L562 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L617 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L654 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L765 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L778 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L824 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L837 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L883 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L924 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L984 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L984 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L1037 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L1127 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L1144 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L1190 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L1271 |
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L51 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L58 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L64 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L87 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L90 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L93 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L96 |
|
Use the latest version v5 of types.json. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L109 |
|
The response of operation:'RedisEnterprise_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L116 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
new-api-version
NotReadyForARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
labels
May 17, 2024
This was referenced May 17, 2024
/azp run |
Commenter does not have sufficient privileges for PR 29141 in repo Azure/azure-rest-api-specs |
revanthballa1188
force-pushed
the
revanth1188-redisenterprise-Microsoft.cache-2024-06-01-preview
branch
from
May 20, 2024 09:42
40eb3de
to
e9a73f6
Compare
revanthballa1188
force-pushed
the
revanth1188-redisenterprise-Microsoft.cache-2024-06-01-preview
branch
from
May 20, 2024 09:50
e9a73f6
to
36e9155
Compare
TimLovellSmith
changed the title
Add new API version 2026-04-01-preview
Add new API version 2024-06-01-preview
May 20, 2024
Breaking changes previously reviewed and approved in #28835. |
mikekistler
added
the
BreakingChange-Approved-Previously
Changes were reviewed and approved in a previous PR
label
May 21, 2024
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
AzureRestAPISpecReview
added
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
and removed
NotReadyForARMReview
labels
May 22, 2024
samsaha-ms
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
May 22, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 22, 2024
samsaha-ms
approved these changes
May 22, 2024
revanthballa1188
added
IDCDevDiv
MergeRequested
Part of the ARM PR review workflow
labels
May 22, 2024
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
* Copy files from preview/2024-03-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-06-01-preview Updated the API version from preview/2024-03-01-preview to preview/2024-06-01-preview. * Added tag for 2024-06-01-preview in readme file * Add Enterprise E1 SKU * fix prettier checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Approved-Previously
Changes were reviewed and approved in a previous PR
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
IDCDevDiv
MergeRequested
Part of the ARM PR review workflow
new-api-version
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.