Liftr Informatica API - Stable version release for SDK generation #29140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
new-api-version
new-rp-namespace
resource-manager
RPaaS
TypeSpec
|
Hi, @almasak, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
This was referenced May 17, 2024
AzureRestAPISpecReview
added
the
ReadyForApiTest
AzureRestAPISpecReview
removed
the
ReadyForApiTest
AzureRestAPISpecReview
added
the
ReadyForApiTest
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Suppression has been added for "OperationIDNounVerb" since the failing check is not applicable for our case, as "startFailedServerlessRuntime" is a single verb-term and not a noun, and is thus a false-positive. Moreover, this API spec already exists for our preview version: Link |
samsaha-ms
reviewed
May 20, 2024
samsaha-ms
reviewed
May 20, 2024
| "swagger": "2.0", | ||
| "info": { | ||
| "title": "Informatica.DataManagement", | ||
| "version": "2024-05-09", |
There was a problem hiding this comment.
Looks like this PR introduces new stable version of swagger, please create base commit for with either previous stable version or preview version(if it was arm reviewed earlier). Please follow: https://eng.ms/docs/products/azure-developer-experience/design/api-specs/api-specs?tabs=openapi
There was a problem hiding this comment.
This is our first version of the API specs (either private or stable) in this repo. Previous preview version is in the private repository:
https://github.com/Azure/azure-rest-api-specs-pr/pull/16995
https://github.com/Azure/azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/informatica
There was a problem hiding this comment.
You could still copy the files in the repo in your local branch and use the script to create a base of it.
Since you have chosen not done it, just FYI, it will take more time to complete the ARM review for this PR.
samsaha-ms
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
@almasak , Please remove |
almasak
removed
the
ARMChangesRequested
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
|
Approving suppression based on author and other ARM reviewers previous conversation over group chat. |
samsaha-ms
added
Approved-Suppression
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
samsaha-ms
approved these changes
May 22, 2024
|
Signed off the PR from ARM as changes were reviewed earlier in private repo under 2023-08-20-preview api version. |
|
@almasak, please follow the Next Steps to Merge section for moving to next step to merge the PR. |
|
Namespace review: |
|
/pr RequestMerge |
microsoft-github-policy-service
bot
added
the
MergeRequested
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
…ure#29140) * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation * Liftr Informatica API - Stable version release for SDK generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.