-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Koyasu221b maps route 2024 05 01 preview test #29139
Closed
Closed
+4,653
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
Important checks have failed. As of today they are not blocking this PR, but in near future they will. Addressing the following failures is highly recommended:
|
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
route.json | 2024-05-01-preview(d7dd926) | 2024-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 4 Errors, 15 Warnings failed [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-preview-2024-05 | package-preview-2024-05(d7dd926) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Route' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Route/preview/2024-05-01-preview/route.json#L78 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Route' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Route/preview/2024-05-01-preview/route.json#L139 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Route' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Route/preview/2024-05-01-preview/route.json#L383 |
|
OperationIdNounVerb |
Per the Noun_Verb convention for Operation Ids, the noun 'Route' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Route/preview/2024-05-01-preview/route.json#L443 |
|
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Route/preview/2024-05-01-preview/route.json#L259 |
||
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L304 |
||
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Route/preview/2024-05-01-preview/route.json#L319 |
||
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L366 |
||
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Route/preview/2024-05-01-preview/route.json#L381 |
||
Schema with type: number should specify format Location: Route/preview/2024-05-01-preview/route.json#L412 |
||
Schema with type: number should specify format Location: Route/preview/2024-05-01-preview/route.json#L412 |
||
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L426 |
||
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Route/preview/2024-05-01-preview/route.json#L441 |
||
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L488 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Route/preview/2024-05-01-preview/route.json#L706 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Route/preview/2024-05-01-preview/route.json#L711 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Route/preview/2024-05-01-preview/route.json#L2439 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Route/preview/2024-05-01-preview/route.json#L2463 |
||
Consider using x-ms-client-flatten to provide a better end user experience Location: Route/preview/2024-05-01-preview/route.json#L2529 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L121 |
|
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Route/preview/2024-05-01-preview/route.json#L136 |
|
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L184 |
|
Error schema should define code and message properties as required.Location: Route/preview/2024-05-01-preview/route.json#L244 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Route/preview/2024-05-01-preview/route.json#L598 |
|
Property should have a defined type. Location: Route/preview/2024-05-01-preview/route.json#L1189 |
|
Property should have a defined type. Location: Route/preview/2024-05-01-preview/route.json#L1194 |
|
Property should have a defined type. Location: Route/preview/2024-05-01-preview/route.json#L1337 |
|
Property should have a defined type. Location: Route/preview/2024-05-01-preview/route.json#L1342 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Route/preview/2024-05-01-preview/route.json#L2132 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.