-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix devcontainer to be ready for development #29135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
serbrech
changed the title
fix devcontainer to have be ready for development
fix devcontainer to be ready for development
May 17, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
reviewed
May 24, 2024
mikeharder
approved these changes
May 25, 2024
Better to get into the habit of running |
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevContainer
The current DevContainer is outdated and when starting a codespace, you need to install a newer node, npm, typespec, etc...
This PR changes the devcontainer configuration so that the codespace is properly configured to start editing the specs.
mcr.microsoft.com/devcontainers/typescript-node:20-bookworm
as the base imagepackages-microsoft-prod.deb
install giton environment start:
node_modules/.bin
folder to the path, so we can calltsp