Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix devcontainer to be ready for development #29135

Merged
merged 22 commits into from
May 25, 2024
Merged

fix devcontainer to be ready for development #29135

merged 22 commits into from
May 25, 2024

Conversation

serbrech
Copy link
Member

@serbrech serbrech commented May 17, 2024

DevContainer

The current DevContainer is outdated and when starting a codespace, you need to install a newer node, npm, typespec, etc...

This PR changes the devcontainer configuration so that the codespace is properly configured to start editing the specs.

  • use mcr.microsoft.com/devcontainers/typescript-node:20-bookworm as the base image
  • install packages-microsoft-prod.deb
  • install git
  • install npm oav

on environment start:

  • install npm packages from packages.json (typespec compiler amongst other)
  • set the node_modules/.bin folder to the path, so we can call tsp

Copy link

openapi-pipeline-app bot commented May 17, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 17, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 17, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 17, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@serbrech serbrech changed the title fix devcontainer to have be ready for development fix devcontainer to be ready for development May 17, 2024
@mikeharder
Copy link
Member

mikeharder commented May 25, 2024

set the node_modules/.bin folder to the path, so we can call tsp

Better to get into the habit of running npx tsp, or if you really want, just install the matching version of tsp globally.

@mikeharder mikeharder merged commit cb5ca0a into main May 25, 2024
31 of 32 checks passed
@mikeharder mikeharder deleted the dev-container branch May 25, 2024 00:13
@mikeharder mikeharder self-assigned this May 28, 2024
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants