Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BastionHost] Add 'Premium' SKU and 'enableSessionRecording' feature #29127

Conversation

abhi7860
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • Add new value for BastionHost SKU - "Premium"

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 16, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 16, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.8) new version base version
bastionHost.json 2024-01-01(8ac0b12) 2023-11-01(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(8ac0b12) package-2024-01(release-network-Microsoft.Network-2024-01-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L38
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L59
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L235
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L369
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L394
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L422
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L572
MissingTypeObject The schema 'BastionHostIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L676
MissingTypeObject The schema 'BastionHostIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L702
MissingTypeObject The schema 'BastionHostPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L731
MissingTypeObject The schema 'networkAcls' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L748
MissingTypeObject The schema 'BastionHost' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L810
MissingTypeObject The schema 'BastionHostListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L841
MissingTypeObject The schema 'BastionShareableLink' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L857
MissingTypeObject The schema 'BastionShareableLinkListRequest' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L884
MissingTypeObject The schema 'BastionShareableLinkListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L909
MissingTypeObject The schema 'BastionActiveSession' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L925
MissingTypeObject The schema 'BastionActiveSessionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L993
MissingTypeObject The schema 'BastionSessionState' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1009
MissingTypeObject The schema 'BastionSessionDeleteResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1029
MissingTypeObject The schema 'SessionIds' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1053
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L44
⚠️ RequiredReadOnlySystemData The response of operation:'BastionHosts_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L88
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L94
⚠️ RequiredReadOnlySystemData The response of operation:'BastionHosts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L134
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L140
⚠️ RequiredReadOnlySystemData The response of operation:'BastionHosts_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L199
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L205
⚠️ PatchSkuProperty The patch operation body parameter schema should contain property 'sku'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L215
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L263
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 16, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net failed [Detail]
  • Code Generator Failed in generating from 3f21674. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.Network [Preview SDK Changes]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard2.0]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net461]
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 3f21674. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Network [Preview SDK Changes]
    • Azure.ResourceManager.Network.1.8.0-alpha.20240520.1.nupkg
    info	[Changelog]
️🔄 azure-sdk-for-python inProgress [Detail]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 3f21674. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-network-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 3f21674. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `BastionHostSKUNamePremium` added to enum type `BastionHostSKUName`
    info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
    info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
    info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
    info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
    info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
    info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
    info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
    info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
    info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
    info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
    info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
    info	[Changelog] - New struct `FirewallPolicyDraft`
    info	[Changelog] - New struct `FirewallPolicyDraftProperties`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
    info	[Changelog] - New struct `HeaderValueMatcher`
    info	[Changelog] - New struct `PacketCaptureSettings`
    info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
    info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
    info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
    info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
    info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
    info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
    info	[Changelog] - New field `EnableSessionRecording` in struct `BastionHostPropertiesFormat`
    info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
    info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
    info	[Changelog] - New field `Identity` in struct `FlowLog`
    info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
    info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
    info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
    info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
    info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
    info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
    info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
    info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
    info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
    info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
    info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 77 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 3f21674. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [Preview SDK Changes]
    • azure-arm-network-33.2.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group FirewallPolicyDeployments
    info	[Changelog]   - Added operation group FirewallPolicyDrafts
    info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
    info	[Changelog]   - Added operation NetworkVirtualAppliances.restart
    info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraft
    info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
    info	[Changelog]   - Added Interface HeaderValueMatcher
    info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
    info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
    info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
    info	[Changelog]   - Added Interface PacketCaptureSettings
    info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
    info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
    info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
    info	[Changelog]   - Added Type Alias InboundSecurityRuleType
    info	[Changelog]   - Added Type Alias NicTypeInRequest
    info	[Changelog]   - Added Type Alias NicTypeInResponse
    info	[Changelog]   - Added Type Alias SharingScope
    info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
    info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
    info	[Changelog]   - Interface BastionHost has a new optional parameter enableSessionRecording
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
    info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
    info	[Changelog]   - Interface FlowLog has a new optional parameter identity
    info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
    info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
    info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
    info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
    info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
    info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
    info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
    info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
    info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
    info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
    info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
    info	[Changelog]   - Added Enum KnownNicTypeInRequest
    info	[Changelog]   - Added Enum KnownNicTypeInResponse
    info	[Changelog]   - Added Enum KnownSharingScope
    info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Premium
    info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 3f21674. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.8.0` to update!
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 3f21674. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@abhi7860
Copy link
Member Author

/pr RequestMerge

@microsoft-github-policy-service microsoft-github-policy-service bot added the MergeRequested Part of the ARM PR review workflow label May 20, 2024
@mentat9
Copy link
Member

mentat9 commented May 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@razvanbadea-msft razvanbadea-msft merged commit ac89c7b into Azure:release-network-Microsoft.Network-2024-01-01 May 21, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review MergeRequested Part of the ARM PR review workflow resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants