-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bizapps #29122
update bizapps #29122
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-preview-2024-04 | package-preview-2024-04(1719d8b) | package-preview-2024-04(dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Schema should have a description or title. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/BusinessApplicationAgents.json#L752 |
||
Missing identifier id in array item property Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/BusinessApplicationAgents.json#L762 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/BusinessApplicationAgents.json#L187 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
5d52e7f
to
3aa5803
Compare
after this pr you reviewed - #28504 the current PR is not for master but for a side branch that we reviewing before taking to main (this is a new feature so no breaking change) mostly rearrange the models (added a sub model) and added a new parameter I see now that I cant ask for an arm review - can you pls add this label for me? thanks a lot! |
…tyInsights-2024-04-01-preview' of https://github.com/dvir-ms/azure-rest-api-specs into dvirnaim-dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview
a3236df
into
Azure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.