-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using common types #29113
Using common types #29113
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
networksecurityperimeter.json | 0000-00-00(b5a426f) | 0000-00-00(main) |
cosmos-db.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
managedCassandra.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
mongorbac.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
notebook.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
privateEndpointConnection.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
privateLinkResources.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
rbac.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
restorable.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
services.json | 2024-05-15(b5a426f) | 2024-05-15(main) |
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L37:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L200:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L253:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L283:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L316:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L349:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L385:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L444:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L503:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L567:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L620:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L647:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L677:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L716:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L758:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L803:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L851:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L893:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L938:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L980:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1019:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1067:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1112:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1160:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1211:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1250:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1292:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1337:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1382:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1421:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄
LintDiff inProgress [Detail]
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/stable/2024-05-15/privateEndpointConnection.json |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 4 Errors, 0 Warnings failed [Detail]
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
SpellCheck: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L49:75 |
HowToFix |
Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L97:75 |
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Adding network security perimeter type definitions to common-types.
@pjohari-ms Looks good so far, I think you'll just want to merge latest main into your source branch, and use your own definition of the configuration name that provides a pattern constraint, if you have one. |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Please fill out the Purpose of this PR and Due diligence checklist and fix the required validations |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
@pjohari-ms I don't see any interesting lintDiff errors here yet, but looks like examples need fixing for ModelValidation errors. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.