Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using common types #29113

Conversation

pjohari-ms
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 15, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger SpellCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it

Copy link

openapi-pipeline-app bot commented May 15, 2024

Swagger Validation Report

️❌BreakingChange: 133 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.9) new version base version
networksecurityperimeter.json 0000-00-00(b5a426f) 0000-00-00(main)
cosmos-db.json 2024-05-15(b5a426f) 2024-05-15(main)
managedCassandra.json 2024-05-15(b5a426f) 2024-05-15(main)
mongorbac.json 2024-05-15(b5a426f) 2024-05-15(main)
notebook.json 2024-05-15(b5a426f) 2024-05-15(main)
privateEndpointConnection.json 2024-05-15(b5a426f) 2024-05-15(main)
privateLinkResources.json 2024-05-15(b5a426f) 2024-05-15(main)
rbac.json 2024-05-15(b5a426f) 2024-05-15(main)
restorable.json 2024-05-15(b5a426f) 2024-05-15(main)
services.json 2024-05-15(b5a426f) 2024-05-15(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L37:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L200:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L253:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L283:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L316:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L349:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L385:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L444:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L503:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L567:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L620:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L647:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L677:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L716:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L758:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L803:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L851:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L893:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L938:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L980:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1019:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1067:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1112:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1160:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1211:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1250:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1292:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1337:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1382:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DocumentDB/stable/2024-05-15/cosmos-db.json#L1421:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄LintDiff inProgress [Detail]
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
readme: specification/cosmos-db/resource-manager/readme.md
json: Microsoft.DocumentDB/stable/2024-05-15/privateEndpointConnection.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
Rule Message
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: diagnosticSettingsVersion
Url: common-types/resource-management/v5/networksecurityperimeter.json#L274:31
ExampleUrl: preview/2024-05-15-preview/examples/NetworkSecurityPerimeterConfigurationList.json#L42:46
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: enabledLogCategories
Url: common-types/resource-management/v5/networksecurityperimeter.json#L274:31
ExampleUrl: preview/2024-05-15-preview/examples/NetworkSecurityPerimeterConfigurationList.json#L43:41
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: diagnosticSettingsVersion
Url: common-types/resource-management/v5/networksecurityperimeter.json#L274:31
ExampleUrl: preview/2024-05-15-preview/examples/NetworkSecurityPerimeterConfigurationGet.json#L42:42
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: enabledLogCategories
Url: common-types/resource-management/v5/networksecurityperimeter.json#L274:31
ExampleUrl: preview/2024-05-15-preview/examples/NetworkSecurityPerimeterConfigurationGet.json#L43:37
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌SpellCheck: 2 Errors, 0 Warnings failed [Detail]
Rule Message
HowToFix Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check
path: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L49:75
HowToFix Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check
path: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L97:75
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 15, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from ff35d4c. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.8.0` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-cosmosdb [Preview SDK Changes]
    • azure_mgmt_cosmosdb-0.7.0-py3-none-any.whl
    • azure-mgmt-cosmosdb-0.7.0.zip
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ff35d4c. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.CosmosDB [Preview SDK Changes] Breaking Change Detected
    • Azure.ResourceManager.CosmosDB.1.4.0-alpha.20240524.1.nupkg
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.CosmosDB.Models.CosmosDBServiceType' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cosmosdb/Azure.ResourceManager.CosmosDB/src/Azure.ResourceManager.CosmosDB.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.CosmosDB/Debug/netstandard2.0/Azure.ResourceManager.CosmosDB.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cosmosdb/Azure.ResourceManager.CosmosDB/src/Azure.ResourceManager.CosmosDB.csproj::TargetFramework=netstandard2.0]
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ff35d4c. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-cosmos-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ff35d4c. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/cosmos/armcosmos [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ff35d4c. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-cosmosdb [Preview SDK Changes]
    • azure-arm-cosmosdb-16.0.0-beta.8.tgz
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from ff35d4c. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.8.0` to update!
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from ff35d4c. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.cosmos-db.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Adding network security perimeter type definitions to common-types.
@TimLovellSmith
Copy link
Member

@pjohari-ms Looks good so far, I think you'll just want to merge latest main into your source branch, and use your own definition of the configuration name that provides a pattern constraint, if you have one.

@TimLovellSmith
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@razvanbadea-msft
Copy link
Contributor

razvanbadea-msft commented May 24, 2024

Please fill out the Purpose of this PR and Due diligence checklist and fix the required validations

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 24, 2024
@TimLovellSmith
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@TimLovellSmith
Copy link
Member

@pjohari-ms I don't see any interesting lintDiff errors here yet, but looks like examples need fixing for ModelValidation errors.

@pjohari-ms pjohari-ms closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants