-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] Update Hibernate Public Docs to remove "Feature in Preview" #29112
Merged
rkmanda
merged 8 commits into
Azure:main
from
jaclin1111:dev/jaclin/updatehibernateNotInpreview
Jun 5, 2024
Merged
[new] Update Hibernate Public Docs to remove "Feature in Preview" #29112
rkmanda
merged 8 commits into
Azure:main
from
jaclin1111:dev/jaclin/updatehibernateNotInpreview
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove "feature in preview"
jaclin1111
requested review from
Sandido,
dkulkarni-ms,
haagha,
MS-syh2qs and
grizzlytheodore
as code owners
May 15, 2024 17:37
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
virtualMachine.json | 2024-03-01(5484c14) | 2024-03-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2024-03-01 | package-2024-03-01(5484c14) | package-2024-03-01(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
GetCollectionResponseSchema |
The response in the GET collection operation 'VirtualMachineRunCommands_List' does not match the response definition in the individual GET operation 'VirtualMachineRunCommands_Get' . Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L36 |
PatchResponseCodes |
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L112 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:secretUrl. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L144 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:sourceVault. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L144 |
LroPatch202 |
The async patch operation should return 202. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L156 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L177 |
LroLocationHeader |
A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L216 |
ParametersInPointGet |
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L245 |
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L306 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L344 |
LroLocationHeader |
A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L457 |
PatchResponseCodes |
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L706 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:secretUrl. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:sourceVault. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:keyUrl. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:createOption. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731 |
LroPatch202 |
The async patch operation should return 202. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L759 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L783 |
LroLocationHeader |
A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L822 |
ParametersInPointGet |
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L848 |
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L916 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L947 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L969 |
LroLocationHeader |
A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1001 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1023 |
ParametersInPost |
hibernate is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1029 |
LroLocationHeader |
A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1062 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1302 |
PostResponseCodes |
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1324 |
ParametersInPost |
skipShutdown is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1330 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01 |
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 15, 2024
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
May 15, 2024
This was referenced May 15, 2024
grizzlytheodore
approved these changes
May 22, 2024
razvanbadea-msft
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
May 24, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 24, 2024
/pr RequestMerge |
microsoft-github-policy-service
bot
added
the
MergeRequested
Part of the ARM PR review workflow
label
Jun 4, 2024
rkmanda
approved these changes
Jun 5, 2024
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
remove "feature in preview" Co-authored-by: Theodore Chang <thchan@microsoft.com>
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Jun 7, 2024
remove "feature in preview" Co-authored-by: Theodore Chang <thchan@microsoft.com>
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Jun 7, 2024
remove "feature in preview" Co-authored-by: Theodore Chang <thchan@microsoft.com>
markcowl
pushed a commit
that referenced
this pull request
Jun 7, 2024
remove "feature in preview" Co-authored-by: Theodore Chang <thchan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
MergeRequested
Part of the ARM PR review workflow
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove "feature in preview" for new hibernate feature in VM