Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Test PR / Update agfood.json #29106

Closed
wants to merge 1 commit into from

Conversation

konrad-jamrozik
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@konrad-jamrozik konrad-jamrozik added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels May 15, 2024
@konrad-jamrozik
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@konrad-jamrozik
Copy link
Member Author

/azp run

Copy link

openapi-pipeline-app bot commented May 15, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    ARM review workflow label is missing! Add /azp run comment to this PR to allow automation to determine where this PR is in the ARM review workflow.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Requirement (resource-manager) has failed. TypeSpec usage is required for all new (aka "greenfield") services. The automation detected this pull request adds at least one new service that is violating this requirement. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp

Copy link

openapi-pipeline-app bot commented May 15, 2024

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
agfood.json 2020-05-12-preview(61a2258) 2020-05-12-preview(main)
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'Extensions_Create' to 'Extensions_Create test'. This will impact generated code.
New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7
Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2020-05-12-preview package-2020-05-12-preview(61a2258) package-2020-05-12-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L56
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L102
ParametersOrder The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L148
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L195
ResourceNameRestriction The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L466
ParametersOrder The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L510
ParametersOrder The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L571
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L596
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L601
TopLevelResourcesListBySubscription The top-level resource 'FarmBeatsExtension' does not have list by subscription operation, please add it.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1093
ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1167
⚠️ PreviewVersionOverOneYear The API version:2020-05-12-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L6
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L30
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L33
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L73
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L79
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L92
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L119
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L122
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L125
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L138
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L165
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L168
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L171
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 15, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 26fb210. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-agrifood [Preview SDK Changes]
    • azure_mgmt_agrifood-1.0.0b1-py3-none-any.whl
    • azure-mgmt-agrifood-1.0.0b1.zip
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 26fb210. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/agrifood/armagrifood [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 26fb210. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-agrifood [Preview SDK Changes]
    • azure-arm-agrifood-1.0.0-beta.6.tgz
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 26fb210. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-agrifood [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-agrifood-1.0.0-beta.2-sources.jar
    • azure-resourcemanager-agrifood-1.0.0-beta.2.jar
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 26fb210. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.agrifood.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@konrad-jamrozik konrad-jamrozik added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels May 15, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2024
@konrad-jamrozik konrad-jamrozik added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 15, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2024
@konrad-jamrozik konrad-jamrozik removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants