-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Test PR / Update agfood.json #29106
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
ARMReview
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
labels
May 15, 2024
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
agfood.json | 2020-05-12-preview(61a2258) | 2020-05-12-preview(main) |
Rule | Message |
---|---|
1008 - ModifiedOperationId |
The operation id has been changed from 'Extensions_Create' to 'Extensions_Create test'. This will impact generated code. New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7 Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10:7 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2020-05-12-preview | package-2020-05-12-preview(61a2258) | package-2020-05-12-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Azure Pipelines successfully started running 4 pipeline(s). |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
NotReadyForARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
labels
May 15, 2024
This was referenced May 15, 2024
konrad-jamrozik
added
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
labels
May 15, 2024
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 15, 2024
konrad-jamrozik
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
May 15, 2024
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 15, 2024
konrad-jamrozik
removed
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
labels
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.