Add new api-version 2024-02-01-preview to main #29105
Open
+16,891
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| operations.json | 2024-02-01-preview(ac5747a) | 2024-01-01(main) |
| operations.json | 2024-02-01-preview(ac5747a) | 2023-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version has a different format 'uri' than the previous one ''. New: common-types/resource-management/v5/types.json#L413:9 Old: common-types/resource-management/v3/types.json#L411:9 |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version has a different format 'uri' than the previous one ''. New: common-types/resource-management/v5/types.json#L413:9 Old: common-types/resource-management/v3/types.json#L411:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 15 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| default | default(ac5747a) | default(main) |
| package-preview-2024-02-01 | package-preview-2024-02-01(ac5747a) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L559 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L598 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L5283 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L5287 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L5297 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L5301 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6209 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6700 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6708 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6713 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6724 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6736 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6741 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6752 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: StackHCIVM/preview/2024-02-01-preview/stackhcivm.json#L6771 |
️❌Avocado: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The example JSON file is not referenced from the swagger file. readme: specification/azurestackhci/resource-manager/readme.md json: preview/2024-02-01-preview/examples/Operations_List.json |
|
The swagger JSON file is not referenced from the readme file. readme: specification/azurestackhci/resource-manager/readme.md json: operations/preview/2024-02-01-preview/operations.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=432404&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning in generating from b053241. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk warn specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml warn specification/azurestackhci/Operations.Management/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-azurestackhci [Preview SDK Changes] Breaking Change Detected- azure-mgmt-azurestackhci-1.0.0b1.zip
- azure_mgmt_azurestackhci-1.0.0b1-py3-none-any.whl
info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation ArcSettingsOperations.begin_initialize_disable_process info [Changelog] - Added operation ArcSettingsOperations.consent_and_install_default_extensions info [Changelog] - Added operation ClustersOperations.begin_extend_software_assurance_benefit info [Changelog] - Added operation ExtensionsOperations.begin_upgrade info [Changelog] - Added operation group DeploymentSettingsOperations info [Changelog] - Added operation group EdgeDevicesOperations info [Changelog] - Added operation group GalleryImagesOperations info [Changelog] - Added operation group GuestAgentOperations info [Changelog] - Added operation group GuestAgentsOperations info [Changelog] - Added operation group HybridIdentityMetadataOperations info [Changelog] - Added operation group LogicalNetworksOperations info [Changelog] - Added operation group MarketplaceGalleryImagesOperations info [Changelog] - Added operation group NetworkInterfacesOperations info [Changelog] - Added operation group OffersOperations info [Changelog] - Added operation group PublishersOperations info [Changelog] - Added operation group SecuritySettingsOperations info [Changelog] - Added operation group SkusOperations info [Changelog] - Added operation group StorageContainersOperations info [Changelog] - Added operation group UpdateRunsOperations info [Changelog] - Added operation group UpdateSummariesOperations info [Changelog] - Added operation group UpdatesOperations info [Changelog] - Added operation group VirtualHardDisksOperations info [Changelog] - Added operation group VirtualMachineInstancesOperations info [Changelog] - Model ArcConnectivityProperties has a new parameter service_configurations info [Changelog] - Model ArcSetting has a new parameter default_extensions info [Changelog] - Model ArcSetting has a new parameter system_data info [Changelog] - Model Cluster has a new parameter connectivity_status info [Changelog] - Model Cluster has a new parameter isolated_vm_attestation_configuration info [Changelog] - Model Cluster has a new parameter principal_id info [Changelog] - Model Cluster has a new parameter resource_provider_object_id info [Changelog] - Model Cluster has a new parameter software_assurance_properties info [Changelog] - Model Cluster has a new parameter system_data info [Changelog] - Model Cluster has a new parameter tenant_id info [Changelog] - Model Cluster has a new parameter type_identity_type info [Changelog] - Model Cluster has a new parameter user_assigned_identities info [Changelog] - Model ClusterNode has a new parameter ehc_resource_id info [Changelog] - Model ClusterNode has a new parameter last_licensing_timestamp info [Changelog] - Model ClusterNode has a new parameter node_type info [Changelog] - Model ClusterNode has a new parameter oem_activation info [Changelog] - Model ClusterNode has a new parameter os_display_version info [Changelog] - Model ClusterPatch has a new parameter principal_id info [Changelog] - Model ClusterPatch has a new parameter tenant_id info [Changelog] - Model ClusterPatch has a new parameter type info [Changelog] - Model ClusterPatch has a new parameter user_assigned_identities info [Changelog] - Model ClusterReportedProperties has a new parameter cluster_type info [Changelog] - Model ClusterReportedProperties has a new parameter manufacturer info [Changelog] - Model ClusterReportedProperties has a new parameter oem_activation info [Changelog] - Model ClusterReportedProperties has a new parameter supported_capabilities info [Changelog] - Model Extension has a new parameter enable_automatic_upgrade info [Changelog] - Model Extension has a new parameter managed_by info [Changelog] - Model Extension has a new parameter system_data info [Changelog] - Model PerNodeExtensionState has a new parameter instance_view info [Changelog] - Model PerNodeExtensionState has a new parameter type_handler_version info [Changelog] - Model PerNodeState has a new parameter arc_node_service_principal_object_id info [Changelog] - Model ProxyResource has a new parameter system_data info [Changelog] - Model Resource has a new parameter system_data info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model ArcSetting no longer has parameter created_at info [Changelog] - Model ArcSetting no longer has parameter created_by info [Changelog] - Model ArcSetting no longer has parameter created_by_type info [Changelog] - Model ArcSetting no longer has parameter last_modified_at info [Changelog] - Model ArcSetting no longer has parameter last_modified_by info [Changelog] - Model ArcSetting no longer has parameter last_modified_by_type info [Changelog] - Model Cluster no longer has parameter created_at info [Changelog] - Model Cluster no longer has parameter created_by info [Changelog] - Model Cluster no longer has parameter created_by_type info [Changelog] - Model Cluster no longer has parameter last_modified_at info [Changelog] - Model Cluster no longer has parameter last_modified_by info [Changelog] - Model Cluster no longer has parameter last_modified_by_type info [Changelog] - Model Extension no longer has parameter created_at info [Changelog] - Model Extension no longer has parameter created_by info [Changelog] - Model Extension no longer has parameter created_by_type info [Changelog] - Model Extension no longer has parameter last_modified_at info [Changelog] - Model Extension no longer has parameter last_modified_by info [Changelog] - Model Extension no longer has parameter last_modified_by_type
Present SDK breaking changes suppressions Model ArcSetting no longer has parameter created_at Model ArcSetting no longer has parameter created_by Model ArcSetting no longer has parameter created_by_type Model ArcSetting no longer has parameter last_modified_at Model ArcSetting no longer has parameter last_modified_by Model ArcSetting no longer has parameter last_modified_by_type Model Cluster no longer has parameter created_at Model Cluster no longer has parameter created_by Model Cluster no longer has parameter created_by_type Model Cluster no longer has parameter last_modified_at Model Cluster no longer has parameter last_modified_by Model Cluster no longer has parameter last_modified_by_type Model Extension no longer has parameter created_at Model Extension no longer has parameter created_by Model Extension no longer has parameter created_by_type Model Extension no longer has parameter last_modified_at Model Extension no longer has parameter last_modified_by Model Extension no longer has parameter last_modified_by_type
Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded in generating from b053241. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json warn specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-azurestackhci [Preview SDK Changes]- pom.xml
- azure-resourcemanager-azurestackhci-1.0.0-beta.5-sources.jar
- azure-resourcemanager-azurestackhci-1.0.0-beta.5.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded in generating from b053241. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json warn specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/readme.md skipped due to azure-sdk-for-go not found in swagger-to-sdk warn specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml warn specification/azurestackhci/Operations.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only showing 120 items here. Refer to log for details.
️✔️sdk/resourcemanager/azurestackhci/armazurestackhci [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New struct `MarketplaceGalleryImageStatus` info [Changelog] - New struct `MarketplaceGalleryImageStatusDownloadStatus` info [Changelog] - New struct `MarketplaceGalleryImageStatusProvisioningStatus` info [Changelog] - New struct `MarketplaceGalleryImages` info [Changelog] - New struct `MarketplaceGalleryImagesListResult` info [Changelog] - New struct `MarketplaceGalleryImagesUpdateRequest` info [Changelog] - New struct `NetworkInterfaceProperties` info [Changelog] - New struct `NetworkInterfaceStatus` info [Changelog] - New struct `NetworkInterfaceStatusProvisioningStatus` info [Changelog] - New struct `NetworkInterfaces` info [Changelog] - New struct `NetworkInterfacesListResult` info [Changelog] - New struct `NetworkInterfacesUpdateRequest` info [Changelog] - New struct `NetworkProfileUpdate` info [Changelog] - New struct `NetworkProfileUpdateNetworkInterfacesItem` info [Changelog] - New struct `NicDetail` info [Changelog] - New struct `Observability` info [Changelog] - New struct `Offer` info [Changelog] - New struct `OfferList` info [Changelog] - New struct `OfferProperties` info [Changelog] - New struct `OptionalServices` info [Changelog] - New struct `OsProfileUpdate` info [Changelog] - New struct `OsProfileUpdateLinuxConfiguration` info [Changelog] - New struct `OsProfileUpdateWindowsConfiguration` info [Changelog] - New struct `PackageVersionInfo` info [Changelog] - New struct `PhysicalNodes` info [Changelog] - New struct `PrecheckResult` info [Changelog] - New struct `PrecheckResultTags` info [Changelog] - New struct `Publisher` info [Changelog] - New struct `PublisherList` info [Changelog] - New struct `PublisherProperties` info [Changelog] - New struct `QosPolicyOverrides` info [Changelog] - New struct `ReportedProperties` info [Changelog] - New struct `Route` info [Changelog] - New struct `RoutePropertiesFormat` info [Changelog] - New struct `RouteTable` info [Changelog] - New struct `RouteTablePropertiesFormat` info [Changelog] - New struct `SKU` info [Changelog] - New struct `SKUList` info [Changelog] - New struct `SKUMappings` info [Changelog] - New struct `SKUProperties` info [Changelog] - New struct `SSHConfiguration` info [Changelog] - New struct `SSHPublicKey` info [Changelog] - New struct `ScaleUnits` info [Changelog] - New struct `SecurityComplianceStatus` info [Changelog] - New struct `SecurityProperties` info [Changelog] - New struct `SecuritySetting` info [Changelog] - New struct `SecuritySettingListResult` info [Changelog] - New struct `SoftwareAssuranceChangeRequest` info [Changelog] - New struct `SoftwareAssuranceChangeRequestProperties` info [Changelog] - New struct `SoftwareAssuranceProperties` info [Changelog] - New struct `Step` info [Changelog] - New struct `Storage` info [Changelog] - New struct `StorageContainerProperties` info [Changelog] - New struct `StorageContainerStatus` info [Changelog] - New struct `StorageContainerStatusProvisioningStatus` info [Changelog] - New struct `StorageContainers` info [Changelog] - New struct `StorageContainersListResult` info [Changelog] - New struct `StorageContainersUpdateRequest` info [Changelog] - New struct `StorageNetworks` info [Changelog] - New struct `StorageProfileUpdate` info [Changelog] - New struct `StorageProfileUpdateDataDisksItem` info [Changelog] - New struct `Subnet` info [Changelog] - New struct `SubnetPropertiesFormat` info [Changelog] - New struct `SubnetPropertiesFormatIPConfigurationReferencesItem` info [Changelog] - New struct `Update` info [Changelog] - New struct `UpdateList` info [Changelog] - New struct `UpdatePrerequisite` info [Changelog] - New struct `UpdateProperties` info [Changelog] - New struct `UpdateRun` info [Changelog] - New struct `UpdateRunList` info [Changelog] - New struct `UpdateRunProperties` info [Changelog] - New struct `UpdateStateProperties` info [Changelog] - New struct `UpdateSummaries` info [Changelog] - New struct `UpdateSummariesList` info [Changelog] - New struct `UpdateSummariesProperties` info [Changelog] - New struct `UserAssignedIdentity` info [Changelog] - New struct `ValidateRequest` info [Changelog] - New struct `ValidateResponse` info [Changelog] - New struct `ValidationStatus` info [Changelog] - New struct `VirtualHardDiskProperties` info [Changelog] - New struct `VirtualHardDiskStatus` info [Changelog] - New struct `VirtualHardDiskStatusProvisioningStatus` info [Changelog] - New struct `VirtualHardDisks` info [Changelog] - New struct `VirtualHardDisksListResult` info [Changelog] - New struct `VirtualHardDisksUpdateRequest` info [Changelog] - New struct `VirtualMachineConfigAgentInstanceView` info [Changelog] - New struct `VirtualMachineInstance` info [Changelog] - New struct `VirtualMachineInstanceListResult` info [Changelog] - New struct `VirtualMachineInstanceProperties` info [Changelog] - New struct `VirtualMachineInstancePropertiesHardwareProfile` info [Changelog] - New struct `VirtualMachineInstancePropertiesHardwareProfileDynamicMemoryConfig` info [Changelog] - New struct `VirtualMachineInstancePropertiesNetworkProfile` info [Changelog] - New struct `VirtualMachineInstancePropertiesNetworkProfileNetworkInterfacesItem` info [Changelog] - New struct `VirtualMachineInstancePropertiesOsProfile` info [Changelog] - New struct `VirtualMachineInstancePropertiesOsProfileLinuxConfiguration` info [Changelog] - New struct `VirtualMachineInstancePropertiesOsProfileWindowsConfiguration` info [Changelog] - New struct `VirtualMachineInstancePropertiesSecurityProfile` info [Changelog] - New struct `VirtualMachineInstancePropertiesSecurityProfileUefiSettings` info [Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfile` info [Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfileDataDisksItem` info [Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfileImageReference` info [Changelog] - New struct `VirtualMachineInstancePropertiesStorageProfileOsDisk` info [Changelog] - New struct `VirtualMachineInstanceStatus` info [Changelog] - New struct `VirtualMachineInstanceStatusProvisioningStatus` info [Changelog] - New struct `VirtualMachineInstanceUpdateProperties` info [Changelog] - New struct `VirtualMachineInstanceUpdateRequest` info [Changelog] - New struct `VirtualMachineInstanceView` info [Changelog] - New struct `VirtualSwitchConfigurationOverrides` info [Changelog] - New field `DefaultExtensions` in struct `ArcSettingProperties` info [Changelog] - New field `Identity` in struct `Cluster` info [Changelog] - New field `EhcResourceID`, `LastLicensingTimestamp`, `NodeType`, `OSDisplayVersion`, `OemActivation` in struct `ClusterNode` info [Changelog] - New field `Identity` in struct `ClusterPatch` info [Changelog] - New field `ConnectivityStatus`, `IsolatedVMAttestationConfiguration`, `ResourceProviderObjectID`, `SoftwareAssuranceProperties` in struct `ClusterProperties` info [Changelog] - New field `ClusterType`, `Manufacturer`, `OemActivation`, `SupportedCapabilities` in struct `ClusterReportedProperties` info [Changelog] - New field `EnableAutomaticUpgrade` in struct `ExtensionParameters` info [Changelog] - New field `ManagedBy` in struct `ExtensionProperties` info [Changelog] - New field `InstanceView`, `TypeHandlerVersion` in struct `PerNodeExtensionState` info [Changelog] - New field `ArcNodeServicePrincipalObjectID` in struct `PerNodeState` info [Changelog] info [Changelog] Total 1 breaking change(s), 692 additive change(s).
Present SDK breaking changes suppressions Function `*ExtensionsClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, Extension, *ExtensionsClientBeginUpdateOptions)` to `(context.Context, string, string, string, string, ExtensionPatch, *ExtensionsClientBeginUpdateOptions)`
Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded in generating from b053241. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read warn specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-azurestackhci [Preview SDK Changes] Breaking Change Detected- azure-arm-azurestackhci-4.0.0.tgz
info [Changelog] - Interface Cluster has a new optional parameter isolatedVmAttestationConfiguration info [Changelog] - Interface Cluster has a new optional parameter principalId info [Changelog] - Interface Cluster has a new optional parameter resourceProviderObjectId info [Changelog] - Interface Cluster has a new optional parameter softwareAssuranceProperties info [Changelog] - Interface Cluster has a new optional parameter tenantId info [Changelog] - Interface Cluster has a new optional parameter typeIdentityType info [Changelog] - Interface Cluster has a new optional parameter userAssignedIdentities info [Changelog] - Interface ClusterNode has a new optional parameter ehcResourceId info [Changelog] - Interface ClusterNode has a new optional parameter lastLicensingTimestamp info [Changelog] - Interface ClusterNode has a new optional parameter nodeType info [Changelog] - Interface ClusterNode has a new optional parameter oemActivation info [Changelog] - Interface ClusterNode has a new optional parameter osDisplayVersion info [Changelog] - Interface ClusterPatch has a new optional parameter principalId info [Changelog] - Interface ClusterPatch has a new optional parameter tenantId info [Changelog] - Interface ClusterPatch has a new optional parameter type info [Changelog] - Interface ClusterPatch has a new optional parameter userAssignedIdentities info [Changelog] - Interface ClusterReportedProperties has a new optional parameter clusterType info [Changelog] - Interface ClusterReportedProperties has a new optional parameter manufacturer info [Changelog] - Interface ClusterReportedProperties has a new optional parameter oemActivation info [Changelog] - Interface ClusterReportedProperties has a new optional parameter supportedCapabilities info [Changelog] - Interface Extension has a new optional parameter enableAutomaticUpgrade info [Changelog] - Interface Extension has a new optional parameter managedBy info [Changelog] - Interface PerNodeExtensionState has a new optional parameter instanceView info [Changelog] - Interface PerNodeExtensionState has a new optional parameter typeHandlerVersion info [Changelog] - Interface PerNodeState has a new optional parameter arcNodeServicePrincipalObjectId info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Added Enum KnownAvailabilityType info [Changelog] - Added Enum KnownCloudInitDataSource info [Changelog] - Added Enum KnownClusterNodeType info [Changelog] - Added Enum KnownComplianceAssignmentType info [Changelog] - Added Enum KnownComplianceStatus info [Changelog] - Added Enum KnownConnectivityStatus info [Changelog] - Added Enum KnownDeploymentMode info [Changelog] - Added Enum KnownDiskFileFormat info [Changelog] - Added Enum KnownExtendedLocationTypes info [Changelog] - Added Enum KnownExtensionManagedBy info [Changelog] - Added Enum KnownHealthState info [Changelog] - Added Enum KnownHyperVGeneration info [Changelog] - Added Enum KnownIpAllocationMethodEnum info [Changelog] - Added Enum KnownManagedServiceIdentityType info [Changelog] - Added Enum KnownOemActivation info [Changelog] - Added Enum KnownPowerStateEnum info [Changelog] - Added Enum KnownProvisioningAction info [Changelog] - Added Enum KnownProvisioningStateEnum info [Changelog] - Added Enum KnownRebootRequirement info [Changelog] - Added Enum KnownSecurityTypes info [Changelog] - Added Enum KnownServiceName info [Changelog] - Added Enum KnownSeverity info [Changelog] - Added Enum KnownSoftwareAssuranceIntent info [Changelog] - Added Enum KnownSoftwareAssuranceStatus info [Changelog] - Added Enum KnownState info [Changelog] - Added Enum KnownStatusLevelTypes info [Changelog] - Added Enum KnownStatusTypes info [Changelog] - Added Enum KnownUpdateRunPropertiesState info [Changelog] - Added Enum KnownUpdateSummariesPropertiesState info [Changelog] - Added Enum KnownVmSizeEnum info [Changelog] - Enum KnownArcSettingAggregateState has a new value Accepted info [Changelog] - Enum KnownArcSettingAggregateState has a new value DisableInProgress info [Changelog] - Enum KnownArcSettingAggregateState has a new value Provisioning info [Changelog] - Enum KnownExtensionAggregateState has a new value Accepted info [Changelog] - Enum KnownExtensionAggregateState has a new value Provisioning info [Changelog] - Enum KnownExtensionAggregateState has a new value UpgradeFailedRollbackSucceeded info [Changelog] - Enum KnownNodeArcState has a new value Accepted info [Changelog] - Enum KnownNodeArcState has a new value DisableInProgress info [Changelog] - Enum KnownNodeArcState has a new value InProgress info [Changelog] - Enum KnownNodeArcState has a new value PartiallyConnected info [Changelog] - Enum KnownNodeArcState has a new value PartiallySucceeded info [Changelog] - Enum KnownNodeArcState has a new value Provisioning info [Changelog] - Enum KnownNodeExtensionState has a new value Accepted info [Changelog] - Enum KnownNodeExtensionState has a new value InProgress info [Changelog] - Enum KnownNodeExtensionState has a new value PartiallyConnected info [Changelog] - Enum KnownNodeExtensionState has a new value PartiallySucceeded info [Changelog] - Enum KnownNodeExtensionState has a new value Provisioning info [Changelog] - Enum KnownProvisioningState has a new value Connected info [Changelog] - Enum KnownProvisioningState has a new value Creating info [Changelog] - Enum KnownProvisioningState has a new value Deleted info [Changelog] - Enum KnownProvisioningState has a new value Deleting info [Changelog] - Enum KnownProvisioningState has a new value DisableInProgress info [Changelog] - Enum KnownProvisioningState has a new value Disconnected info [Changelog] - Enum KnownProvisioningState has a new value Error info [Changelog] - Enum KnownProvisioningState has a new value InProgress info [Changelog] - Enum KnownProvisioningState has a new value Moving info [Changelog] - Enum KnownProvisioningState has a new value NotSpecified info [Changelog] - Enum KnownProvisioningState has a new value PartiallyConnected info [Changelog] - Enum KnownProvisioningState has a new value PartiallySucceeded info [Changelog] - Enum KnownProvisioningState has a new value Updating info [Changelog] - Enum KnownStatus has a new value DeploymentFailed info [Changelog] - Enum KnownStatus has a new value DeploymentInProgress info [Changelog] - Enum KnownStatus has a new value DeploymentSuccess info [Changelog] - Enum KnownStatus has a new value Failed info [Changelog] - Enum KnownStatus has a new value InProgress info [Changelog] - Enum KnownStatus has a new value NotSpecified info [Changelog] - Enum KnownStatus has a new value Succeeded info [Changelog] - Enum KnownStatus has a new value ValidationFailed info [Changelog] - Enum KnownStatus has a new value ValidationInProgress info [Changelog] - Enum KnownStatus has a new value ValidationSuccess info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Operation Extensions.beginUpdate has a new signature info [Changelog] - Operation Extensions.beginUpdateAndWait has a new signature info [Changelog] - Class AzureStackHCIClient has a new signature info [Changelog] - Interface ArcSetting no longer has parameter createdAt info [Changelog] - Interface ArcSetting no longer has parameter createdBy info [Changelog] - Interface ArcSetting no longer has parameter createdByType info [Changelog] - Interface ArcSetting no longer has parameter lastModifiedAt info [Changelog] - Interface ArcSetting no longer has parameter lastModifiedBy info [Changelog] - Interface ArcSetting no longer has parameter lastModifiedByType info [Changelog] - Interface Cluster no longer has parameter createdAt info [Changelog] - Interface Cluster no longer has parameter createdBy info [Changelog] - Interface Cluster no longer has parameter createdByType info [Changelog] - Interface Cluster no longer has parameter lastModifiedAt info [Changelog] - Interface Cluster no longer has parameter lastModifiedBy info [Changelog] - Interface Cluster no longer has parameter lastModifiedByType info [Changelog] - Interface Extension no longer has parameter createdAt info [Changelog] - Interface Extension no longer has parameter createdBy info [Changelog] - Interface Extension no longer has parameter createdByType info [Changelog] - Interface Extension no longer has parameter lastModifiedAt info [Changelog] - Interface Extension no longer has parameter lastModifiedBy info [Changelog] - Interface Extension no longer has parameter lastModifiedByType
Present SDK breaking changes suppressions Class AzureStackHCIClient has a new signature Interface ArcSetting no longer has parameter createdAt Interface ArcSetting no longer has parameter createdBy Interface ArcSetting no longer has parameter createdByType Interface ArcSetting no longer has parameter lastModifiedAt Interface ArcSetting no longer has parameter lastModifiedBy Interface ArcSetting no longer has parameter lastModifiedByType Interface Cluster no longer has parameter createdAt Interface Cluster no longer has parameter createdBy Interface Cluster no longer has parameter createdByType Interface Cluster no longer has parameter lastModifiedAt Interface Cluster no longer has parameter lastModifiedBy Interface Cluster no longer has parameter lastModifiedByType Interface Extension no longer has parameter createdAt Interface Extension no longer has parameter createdBy Interface Extension no longer has parameter createdByType Interface Extension no longer has parameter lastModifiedAt Interface Extension no longer has parameter lastModifiedBy Interface Extension no longer has parameter lastModifiedByType Operation Extensions.beginUpdate has a new signature Operation Extensions.beginUpdateAndWait has a new signature
Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️❌ azure-resource-manager-schemas failed [Detail]
❌Code Generator Failed in generating from b053241. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'... cmderr [initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'... cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1 cmderr [initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1 cmderr [initScript.sh] npm notice To update run: npm install -g npm@10.8.1 cmderr [initScript.sh] npm notice error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read warn specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/readme.md skipped due to azure-resource-manager-schemas not found in swagger-to-sdk command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cmderr [generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500 cmderr [generateScript.sh] return new TSError(diagnosticText, diagnosticCodes) cmderr [generateScript.sh] ^ cmderr [generateScript.sh] TSError: ⨯ Unable to compile TypeScript: cmderr [generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig. cmderr [generateScript.sh] at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12) cmderr [generateScript.sh] at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19) cmderr [generateScript.sh] at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36) cmderr [generateScript.sh] at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32) cmderr [generateScript.sh] at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43) cmderr [generateScript.sh] at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) cmderr [generateScript.sh] at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12) cmderr [generateScript.sh] at Module.load (node:internal/modules/cjs/loader:1203:32) cmderr [generateScript.sh] at Function.Module._load (node:internal/modules/cjs/loader:1019:12) cmderr [generateScript.sh] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh warn Skip package processing as generation is failed warn specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml skipped due to azure-resource-manager-schemas not found in tspconfig.yaml warn specification/azurestackhci/Operations.Management/tspconfig.yaml skipped due to azure-resource-manager-schemas not found in tspconfig.yaml error ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded in generating from b053241. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json warn specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/readme.md skipped due to azure-powershell not found in swagger-to-sdk warn specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml warn specification/azurestackhci/Operations.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.azurestackhci.DefaultTag [Preview SDK Changes]- Az.StackHci.0.1.0.nupkg
Generated ApiView
|
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29105 in repo Azure/azure-rest-api-specs |
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
This was referenced May 16, 2024
|
Do I need to be in any security group to add and remove labels? I am able to do this in the -pr repo but am not able to do it here. |
markcowl
requested changes
May 16, 2024
specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/main.tsp
Show resolved
Hide resolved
mikekistler
added
the
BreakingChange-Approved-Benign
|
Please fill out the Purpose of this PR and Due diligence checklist. |
razvanbadea-msft
removed
WaitForARMFeedback
Please respond to this. |
TimLovellSmith
added
the
WaitForARMFeedback
|
Please tell me why the typespec validation is failing |
|
@shraddhasun Regarding the TypeSpec validation failures, you can take a look at the lines right above the red error line. https://dev.azure.com/azure-sdk/public/_build/results?buildId=3827382&view=logs&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=0f4aa080-c997-58ca-481c-4930865ae0f8&l=376 |
gary-x-li
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
mikeharder
reviewed
May 29, 2024
specification/azurestackhci/Operations.Management/tspconfig.yaml
Outdated
Show resolved
Hide resolved
mikeharder
reviewed
May 29, 2024
specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Harder <mharder@microsoft.com>
…t/tspconfig.yaml Co-authored-by: Mike Harder <mharder@microsoft.com>
shraddhasun
added
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Is there a base commit that I can compare to? The file |
gary-x-li
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
Its our first api-version in typespec. That file has been generated by typespec. Previously, we had different files for each resource. This api-version has already been added to RPSaaSMaster |
shraddhasun
added
WaitForARMFeedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.