Add SiteExtension.proj to replace build-extension.ps1 #10168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
May 16, 2024
| os: windows | ||
|
|
||
| variables: | ||
| ${{ if or( eq( variables['Build.Reason'], 'PullRequest' ), and( not( contains( variables['Build.SourceBranch'], 'release/inproc6/4.' ) ), not( contains( variables['Build.SourceBranch'], 'release/inproc8/4.' ) ), not( contains( variables['Build.SourceBranch'], 'release/4.' ) ), not( contains( variables['Build.SourceBranch'], 'release/ExtensionsMetadataGenerator/' ) ) ) ) }}: |
There was a problem hiding this comment.
Shall we remove the "release/inproc6/4" and "release/inproc8/4" usage here?
There was a problem hiding this comment.
I have updated that in a different PR: #10171
kshyju
reviewed
May 16, 2024
| @@ -42,9 +42,7 @@ | |||
| <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.1" /> | |||
| <PackageReference Include="Microsoft.Azure.DocumentDB.Core" Version="2.11.2" /> | |||
| <PackageReference Include="Microsoft.Azure.EventHubs" Version="2.1.0" /> | |||
| <PackageReference Include="Microsoft.Azure.Functions.NodeJsWorker" Version="3.10.0" /> | |||
There was a problem hiding this comment.
The tests are not using anything from these packages?
There was a problem hiding this comment.
They are now brought in through worker.props at the top.
kshyju
reviewed
May 16, 2024
| <GetFileHash Files="@(_FilesToHash)" HashEncoding="base64"> | ||
| <Output TaskParameter="Items" ItemName="_HashedFiles" /> | ||
| </GetFileHash> | ||
| </Target> |
There was a problem hiding this comment.
See worker.props CleanDotnetWorkerFiles target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
This PR introduces a new project
WebHost.Script.SiteExtension, which is a replacement forbuild-extension.ps1. This project can be used viadotnetCLI to restore, build, and publish all the artifacts needed for the Antares site extension.Other Changes
update-hostreferences.ps1, this is no longer used anywhereworkers.propsfile. Left python out due to code owners, but ideally python will be moved there as well.ZipPublish.targets.RuntimeIdentifiersadded toWebHost.csproj. Having this set of identifiers listed improves the restore task (otherwise each time you want to use a different runtime, you have to re-restore).