Refactor to put the AZ CLI related calls behind an interface #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still to do:# - Create configurtion to select telemetry type (e.g. Aria, or none) - Capture the use of the help command that has slightly different path - Other telemetry events - Cleanup
Also includes work in progress funnel telemetry for ai init
… maintenance" This reverts commit 760b4dc.
This reverts commit a939526.
- Use classes directly to deserialize. This makes future maintenance easier and clearer - Updated list box picker to allow choosing a "value". Also added classes and interface to make this more generic
- Fixed bug where python installed using .msi on Windows would not work - Improved robustness of deleting temporary files - Fixed null reference exception in some cases in python runner - Fixed variable name typo - Remove unnecessary new line in config.json that was causing inconsistent line endings on windows - Fix bug in parsing config.json where it was not handling empty config.json or invalid JSON correctly
- Project Existing works - Project new
- Simplified the wrapping with telemetry code - Simplified ITelemetry to remove async - Added documtation to ITelemetry code - Minor bug fixes
Also includes some "integration" tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following interfaces:
Each of these abstracts way the details of how things are retrieved (e.g. getting a list of AI Services resources) or handled making it simpler to swap them out later. All of their methods are asynchronous, and return a ClientResult<>. This makes it simpler for calling code to inspect errors and decide whether to throw exceptions or not. The ClientResult struct contains helper methods for this.
Model classes have also been added to streamline deserialization into concrete types, as well as helper attributes and JSON converters to make it easier to retrieve nested properties. This will reduce the need for deserialization code and make it easier to standardize our code base.