fix the float based enum issue #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
archerzz
approved these changes
May 20, 2024
chunyu3
reviewed
May 20, 2024
| @@ -76,32 +76,7 @@ public static InputEnumType CreateEnumType(ref Utf8JsonReader reader, string? id | |||
| throw new JsonException("Enum must have at least one value"); | |||
| } | |||
|
|
|||
| InputPrimitiveType? currentType = null; | |||
There was a problem hiding this comment.
Why remove the value type creation and validation? we may still need check the enum value types consistence.
There was a problem hiding this comment.
I will introduce a fix for this in a new PR to make it throws a proper exception
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4724
Description
Our float based enums are generated as based on int if all existing values are ints. For code examples please check the above issue.
This is incorrect and fixing it could be a breaking change - because the ctor changes for that enum:
but we could get breaking changes if we do not fix it, and users cannot put float values into this enum which is just wrong.
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?