Explicity write http headers on streaming endpoints #47796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
status/2-code-review
kind/bugfix
|
Added an |
thaJeztah
reviewed
May 14, 2024
cpuguy83
force-pushed
the
fix_superfluous_write_header
branch
from
f30c263
to
b19aca4
Compare
thaJeztah
approved these changes
May 16, 2024
This works around issues with the otel http handler wrapper causing multiple calls to `WriteHeader` when a `Flush` is called before `Write`. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_superfluous_write_header
branch
from
b19aca4
to
707ab48
Compare
|
I think its fine to move it to internal, however I'm not sure about the updated implementation. |
I'd have to get rid of the changes made to workaround this superfluous writeheader issue, but the rest of the implementation has been left as-is (with one exception, the removal of a func that had a comment saying it really shouldn't be used) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superfluous response.WriteHeader call#47715This works around issues with the otel http handler wrapper causing multiple calls to
WriteHeaderwhen aFlushis called beforeWrite.closes #47448