Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): allow and escape Kotlin keywords as package identifier, closes #9743 #9799

Merged
merged 8 commits into from
May 28, 2024

Conversation

pewsheen
Copy link
Contributor

@pewsheen pewsheen commented May 16, 2024

Issue: #9743
Depends: tauri-apps/cargo-mobile2#328

How to test

  • Create a project named with Kotlin keyword, such as when or object
  • Modify identifier in tauri.config.json -> aa.fun.tauri.dev
  • Call cargo tauri android init - Should be able to init, and the package name in src-tauri/gen/android/app/src/main/java/aa/fun/tauri/when/MainActivity.kt should be "aa.`fun`.tauri.`when`"
  • Able to run cargo tauri android dev

TODO

@pewsheen pewsheen marked this pull request as ready for review May 28, 2024 03:48
@pewsheen pewsheen requested a review from a team as a code owner May 28, 2024 03:48
@lucasfernog lucasfernog merged commit 71a5e2b into tauri-apps:dev May 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants