CI: fix toolstate publishing

[Kobzol]

Toolstate publishing after something broke was not working (discovered here). The toolstate env. vars should only be needed for the publishing step, so I moved them there.

The toolstate script is also being checked in mingw-check on PR and auto CI, but it doesn't really seem to do anything, and it shouldn't require the token.

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ChrisDenton]

It's pretty impressive that toolstate has presumably been passing for years without a single failure

[Kobzol]

This was broken by my large CI restructuring that was finished ~2 weeks ago.

[ChrisDenton]

Ah! That makes more sense.

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 7b6a3d0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7b6a3d0 with merge 84b9b6d...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 84b9b6d to master...

[rust-timer]

Finished benchmarking commit (84b9b6d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.459s -> 669.294s (0.12%)
Artifact size: 316.25 MiB -> 316.25 MiB (0.00%)

[ehuss]

@Kobzol Toolstate publishing seems to be broken since this PR. From https://github.com/rust-lang-nursery/rust-toolstate/commits/master/ there are no commits since before this PR landed. Is this something you can look into?

[Kobzol]

I am trying to make sense of toolstate publishing, and now I wonder if it has even working before. https://github.com/rust-lang-nursery/rust-toolstate/blob/master/_data/latest.json shouldn't this file be updated when anything changes? It seems like it hasn't been updated for two years. There are various comments in bootstrap code and the Python/Bash script that claim that latest.json should be updated on changes, but this does not seem to happen.

[ehuss]

I believe the latest.json file is only modified when there is a change in status (going from passing to failing or vice versa). It's very likely there hasn't been a change in a while. The history file is what gets updated with every merge.

[ehuss]

The nomicon status switched to failing in #124050 which should have updated the file.

[Kobzol]

It looks like this broke two years ago then. If you take a look at the history (https://github.com/rust-lang-nursery/rust-toolstate/commits/master/_data/latest.json), there were updates from time to time (every few days), but then it just stopped.

[ehuss]

There were frequent updates because miri frequently broke. Then miri was switched to a subtree and removed from the toolstate system. That left just the books, which don't break very often.

[Kobzol]

I wonder if it's even worth it to keep this if it breaks once every two years 😆 Maybe we should just switch everything to subtrees. Anyway, it looks like the issue is with updating the history, not latest.json, I'll try to investigate more.

[ehuss]

Anyway, it looks like the issue is with updating the history, not latest.json

Why does it seem that way? #124050 should have switched the nomicon from passing to failing in latest.json. The history should also be updated on every merge. It seems like all pushes to the toolstate repo aren't working.

[Kobzol]

Yeah, that's what I meant. This PR fixed (hopefully) updating of latest.json, but in the process broke updating of the history, which in turn broke updating of latest.json :) I'll send a PR with a fix soon.