ticdc: support detecting the Kafka cluster version automatically (#10854) #11123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
contribution
ti-chi-bot
bot
added
the
do-not-merge/cherry-pick-not-approved
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
removed
the
do-not-merge/cherry-pick-not-approved
|
/retest |
CharlesCheung96
approved these changes
May 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10854
What problem does this PR solve?
Issue Number: close #10852
What is changed and how it works?
Add Kafka version detect. Connect a broker and use
ApiVersionsRequestto getApiKeysandMaxVersion, according toMaxVersioninfer the Kafka version.Test:
ticdc instance: v8.0.0-master-dirty
pd instance:v7.6.0
tikv instance:v7.6.0
tidb instance:v7.6.0
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
not sure.
Do you need to update user documentation, design documentation or monitoring documentation?
no.
Release note