Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(laravel): add aliases laravel 11 #12354

Merged
merged 1 commit into from
May 22, 2024
Merged

feat(laravel): add aliases laravel 11 #12354

merged 1 commit into from
May 22, 2024

Conversation

rizkyilhampra
Copy link
Contributor

@rizkyilhampra rizkyilhampra commented Apr 15, 2024 •
edited

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Added pamcl alias for php artisan make:class
  • Added pamen alias for php artisan make:enum
  • Added pami alias for php artisan make:interface
  • Added pamtr alias for php artisan make:trait

Other comments:

Laravel version 11 introduced new artisan commands, see https://laravel.com/docs/11.x/releases#new-artisan-commands. I think it would be nice to have this aliases for laravel plugin makers alias.

@rizkyilhampra
feat(laravel): add aliases for new artisan commands
39efc40 
adds aliases for the new artisan commands introduced in laravel 11:
- `pamcl` for `php artisan make:class`
- `pamen` for `php artisan make:enum`
- `pami` for `php artisan make:interface`
- `pamtr` for `php artisan make:trait`
@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request labels Apr 15, 2024
larson-carter
larson-carter approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@larson-carter larson-carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think that we need to merge this as laravel 11 is fairly new, and these new artisan commands are important and are not alias to alias relationship based.

carlosala
carlosala approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosala carlosala changed the title feat(laravel): add aliases for new artisan commands laravel 11 feat(laravel): add aliases laravel 11 May 22, 2024
@carlosala carlosala merged commit 41d2029 into ohmyzsh:master May 22, 2024
1 check passed
@carlosala
Copy link
Member

Thanks Rizky!

Thanks Larson as well 😉

@larson-carter
Copy link
Member

Thank you @carlosala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larson-carter larson-carter larson-carter approved these changes

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rizkyilhampra @carlosala @larson-carter