Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create QC Report for Obsolete terms in reference to Mondo Branches #6766

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

matentzn
Copy link
Member

No description provided.

@twhetzel
Copy link
Collaborator

twhetzel commented Oct 28, 2023

@matentzn @hrshdhgd will this PR be merged into master? As well as the files be cleaned up to remove the commented out lines?

@hrshdhgd
Copy link
Member

Hey @twhetzel , I'll let Nico decide.

@twhetzel
Copy link
Collaborator

Oh, this is a PR from the script I am working on not the PR for the Branch Review table script. I don't know why Nico created a PR for this.

@matentzn
Copy link
Member Author

matentzn commented Nov 1, 2023

Oh, this is a PR from the script I am working on not the PR for the Branch Review table script. I don't know why Nico created a PR for this.

Its good to always have draft PRs! This helps with transparency!

@twhetzel twhetzel changed the title Generate Branch stats table Create QC Report for Obsolete terms in reference to Mondo Branches Nov 7, 2023
@matentzn
Copy link
Member Author

matentzn commented Dec 6, 2023

@twhetzel can we close or otherwise handle this PR so it is out of the way? I lost track of where what is..

@twhetzel
Copy link
Collaborator

twhetzel commented Dec 6, 2023

I mentioned that there are a few things to sort out about this and discuss in our next 1:1 so it needs to stay for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be here

Copy link
Collaborator

@twhetzel twhetzel Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and it's location is where it is in the Draft PR to create the branches for curation review and is needed in this code so that is why it is currently here. I agree, that the location in the repo does not seem idea. What are your thoughts on where this file should be?

This commit renames the mondo intermediate goals into a more sane format, using `tmp/mondo-branch-` for goals that are computed from specific branches, and `tmp/mondo-release-latest-` for goals that are obtained from a release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants