Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margins on color schemes settings page #16291

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix margins on color schemes settings page #16291

wants to merge 1 commit into from
+6 −14

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Nov 11, 2023 •
edited

Summary of the Pull Request

This increases the left and right margins of the contents of the color schemes settings page so that they line up correctly with the page header.

References and Relevant Issues

Addresses #16290.

Detailed Description of the Pull Request / Additional comments

  • Replaced the Grid with a StackPanel to be consistent with other settings pages

Validation Steps Performed

Visually verified the changes.

Before:
image

After:
image

PR Checklist

@chausner chausner mentioned this pull request Nov 11, 2023
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Nov 11, 2023
DHowett
DHowett requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind testing this at different window sizes? There's a breakpoint between small/medium/large that results in slightly different margins on these components.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 16, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 23, 2023
@chausner chausner marked this pull request as draft November 28, 2023 20:17
@chausner
Copy link
Contributor Author

Thanks! Would you mind testing this at different window sizes? There's a breakpoint between small/medium/large that results in slightly different margins on these components.

Switching this PR to Draft for now since the behaviour at the breakpoint is indeed not 100% right. Will check if I can find a proper fix for it.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Nov 28, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.21 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett requested changes

@lhecker lhecker lhecker approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging this pull request may close these issues.

Inconsistent margins on color schemes settings page
4 participants
@chausner @DHowett @lhecker @zadjii-msft