Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix risk profiles exceeding one million #1313

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

justinhaaheim
Copy link
Contributor

This fixes #1310 by limiting the calculation in calculatePersonRiskEach to a maximum of one million.

@netlify
Copy link

netlify bot commented Jan 12, 2022

✔️ Deploy Preview for microcov ready!

🔨 Explore the source changes: 790c0be

🔍 Inspect the deploy log: https://app.netlify.com/sites/microcov/deploys/61de99d5e1b05700082b86dd

😎 Browse the preview: https://deploy-preview-1313--microcov.netlify.app

@oxytocinlove oxytocinlove self-requested a review January 12, 2022 15:49
Copy link
Contributor

@oxytocinlove oxytocinlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I think we wanted to use the fix in https://microcovid.slack.com/archives/C019MJ8RK45/p1641845839001200 though

@justinhaaheim
Copy link
Contributor Author

Ah - got it. I'll take a whack at that.

@tkpwaeub
Copy link

tkpwaeub commented Jan 26, 2022

Ok but please note that this isn't really how probability works. If you roll a million sided die a million times the chance of getting a 19 on one of those rolls is roughly 63% (1-(1/e)) It takes about 4.6 million rolls to clear 99%. I don't see a need for a cap as long as this nuance is explained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain activities >1 Mn microcovids (e.g., bar = 2 Mn)
3 participants