Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sentry import to function #9289

Merged
merged 2 commits into from
May 18, 2024
Merged

Move sentry import to function #9289

merged 2 commits into from
May 18, 2024

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented May 16, 2024 •
edited

Closes #9292

Fixes issue where sentry is None if imported before setup() is called (as per this comment).

Technical

Testing

Screenshot

Stakeholders

@jimchamp jimchamp marked this pull request as ready for review May 16, 2024 18:30
@jimchamp jimchamp added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label May 16, 2024
@mekarpeles mekarpeles self-assigned this May 18, 2024
@mekarpeles mekarpeles merged commit 3513f54 into internetarchive:master May 18, 2024
4 checks passed
@jimchamp jimchamp deleted the bug/sentry-imported-as-none branch May 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mekarpeles mekarpeles

Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sentry object imported before instantiation
2 participants
@jimchamp @mekarpeles