Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mybooks List page title out of header, avoid overflowing Follow & Edit widgets #9285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move mybooks List page title out of header, avoid overflowing Follow & Edit widgets #9285

wants to merge 2 commits into from

Conversation

mekarpeles
Copy link
Member

Closes #9229

Needs to be tested

Technical

Testing

Screenshot

Stakeholders

@github-actions github-actions bot added the Priority: 2 Important, as time permits. [managed] label May 16, 2024
@mekarpeles mekarpeles added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label May 16, 2024
@RayBB
Copy link
Collaborator

RayBB commented May 16, 2024

@mekarpeles looks good on desktop. Mobile could still use some work.

before after
Screen Shot 2024-05-16 at 18 52 59 Screen Shot 2024-05-16 at 18 53 24
Screen Shot 2024-05-16 at 18 54 55 Screen Shot 2024-05-16 at 18 56 04

@RayBB RayBB added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label May 16, 2024
@mekarpeles
Copy link
Member Author

I'll throw on testing and see if there's a change we can make to the flex strategy or breakpoint to clean this up. Thank you

@mekarpeles
Copy link
Member Author

mekarpeles commented May 17, 2024 •
edited

  • .mybooks-details header needs to flex-wrap: wrap;
  • .account-breadcrumb probably needs to nowrap
  • Possibly flex-wrap: wrap;
    Remove flex:1 from breadcrumb-wrapper?

Edit btn needs order:1 and should probably come before social-wrapper

Proposal?

Screenshot 2024-05-17 at 8 59 49 AM Screenshot 2024-05-17 at 7 33 43 AM Screenshot 2024-05-17 at 7 35 53 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RayBB RayBB

Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Needs: Testing On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 2 Important, as time permits. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

My Books "Followers" widget conflicting with List page long titles
2 participants
@mekarpeles @RayBB