Separate template for search facets from work_search.html #9276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
commented
May 15, 2024
| </div> | ||
| </div> | ||
| </div> | ||
| $:render_template('search/work_search_facets', facet_map, param, facet_counts=search_response.facet_counts) |
There was a problem hiding this comment.
Set facet_counts=None here to test async_load mode.
mekarpeles
added
Priority: 2
cdrini
approved these changes
May 24, 2024
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #7271
Moves search facets sidebar into its own template. The new
work_search_facetstemplate supports asynchronous loading, and will displayLoading...indicators whenfacet_countsisNone.Technical
Testing
As of now, there is no way to trigger
async_loadmode via the UI. However, you can make the following change towork_search.htmlto view the loading indicators:https://github.com/internetarchive/openlibrary/pull/9276/files#r1602125790
Screenshot
Facet sidebar when
facet_countsisNone.Stakeholders