Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentry object imported before instantiation #9292

Closed
jimchamp opened this issue May 16, 2024 · 0 comments · Fixed by #9289
Closed

sentry object imported before instantiation #9292

jimchamp opened this issue May 16, 2024 · 0 comments · Fixed by #9289
Assignees
@jimchamp
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] registration Theme: Analytics Regarding metrics, stats, and analytics Type: Bug Something isn't working. [managed]
Milestone
Sprint 2024-05

Comments

@jimchamp
Copy link
Collaborator

Problem

The sentry object that is used in the account registration flow is never instantiated.

Evidence / Screenshot

Link to Sentry event that was triggered by this issue.

Relevant URL(s)

openibrary.org/account/create

Reproducing the bug

  1. Go to /account/create
  2. Submit the form with invalid data
  3. Check the error logs
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders
@jimchamp jimchamp added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 16, 2024
@jimchamp jimchamp mentioned this issue May 16, 2024
Merged
@mekarpeles mekarpeles added Priority: 1 Do this week, receiving emails, time sensitive, . [managed] registration Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Theme: Analytics Regarding metrics, stats, and analytics and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 18, 2024
@mekarpeles mekarpeles added this to the Sprint 2024-05 milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimchamp jimchamp

Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] registration Theme: Analytics Regarding metrics, stats, and analytics Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2024-05
Development

Successfully merging a pull request may close this issue.

Move sentry import to function jimchamp/openlibrary
2 participants
@mekarpeles @jimchamp