Paligemma - fix slow tests, add bf16 and f16 slow tests #30851
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
OOO but the models are gated @ydshieh , the CI bot needs access for testing, not sure how to do it! (the run-slow works apart from that 💯 ) |
|
@molbap for that you can use |
|
cc @ydshieh should be good to go! |
There was a problem hiding this comment.
Thank you @molbap ! LGTM.
I am not sure I understand the to replace what is used part in this comment
Let' s make sure we test the preprocessing to replace what is used
(what is what and what is used here).
I mean it might be good to be more precise - but maybe I lack some context
|
Apparently it comes from Llava code - I have no idea what this comment means! maybe @younesbelkada ? |
|
In this case, we can merge, and once @younesbelkada has answered, we can update the comments in another PR (if needed) |
|
If that comment is that confusing, let's just remove it in another PR (both here and in LLava testing file). WDTY? |
* fix slow tests, add bf16 and f16 slow tests * few fixes * [run-slow]paligemma * add gate decorator * [run-slow]paligemma * add missing gating * [run-slow]paligemma * [run-slow]paligemma
* fix slow tests, add bf16 and f16 slow tests * few fixes * [run-slow]paligemma * add gate decorator * [run-slow]paligemma * add missing gating * [run-slow]paligemma * [run-slow]paligemma
What does this PR do?
As per PR title.
cc @ydshieh