Fix low cpu mem usage tests #30808
Merged
Fix low cpu mem usage tests #30808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
force-pushed
the
fix_low_cpu_mem_usage_tests
branch
from
9c7725a
to
2fac6e3
Compare
ArthurZucker
approved these changes
May 20, 2024
ydshieh
approved these changes
May 21, 2024
In this PR, I fixed the common tests. The issue was that the tests were not designed correctly ( device placement issue ). As for the failing test on UdopModel, this is an issue on the modeling code. With my fix, we can load UdopModel with low_cpu_mem_usage=True. So it's more an issue on transformers. |
itazap
pushed a commit
that referenced
this pull request
May 24, 2024
* Fix tests * fix udop failing test * remove skip * style
itazap
pushed a commit
that referenced
this pull request
May 30, 2024
* Fix tests * fix udop failing test * remove skip * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the common tests about
low_cpu_mem_usage(covered in accelerate_tests). The issue that we had was that we moved one of the model to cuda while the other was on cpu. Hence, we get an error while trying to compare those two models. After fixing the issue on the tests, the only failing model is UdopModel that I fixed (we need to tie the weights in_tie_weights. Otherwise, it won't work withlow_cpu_mem_usage)See the run here with most of the tests passing
Furthermore, I'm running accelerate tests on every model to see if we still have failing tests + check if there are any failing tests for model parallelism, cpu_offload, disk_offload.
The other failing tests are fixed here. @ydshieh for viz