-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sh-admin): improved error handling and dynamic user actions in admin dashboard #4044
base: patch
Are you sure you want to change the base?
refactor(sh-admin): improved error handling and dynamic user actions in admin dashboard #4044
Conversation
0398f7d
to
506245d
Compare
506245d
to
d926415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoelJacobStephen is this PR focused only on some admin and user error management because there are other errors related to workspace and settings left.
@nivedin The newly introduced error handling is only for common errors that are returned from the backend through graphql queries. It does not replace error messages created solely in the frontend (Example: There are error messages that are created in the frontend by only checking if the graphql query has been successful or not without checking the specific error message returned in the graphql response). I will slowly be moving to this style of error handling moving forward in the dashboard. |
Ticket
Closes HFE-514
Description
This PR focuses on improving error handling and user actions in the admin dashboard. Recurring errors returned from the backend are stored, and are paired with appropriate error messages to improve error handling in the dashboard. The action bar in the users page is made to be more dynamic where buttons appear only when the action is relevant based on the selection made by the user
Example:
Make Admin
button is not shown when selected users are all adminsObjectives
Recording
Screen.Recording.2024-05-07.at.10.49.43.AM.mov
Checks