Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sh-admin): improved error handling and dynamic user actions in admin dashboard #4044

Open
wants to merge 14 commits into
base: patch
Choose a base branch
from

Conversation

JoelJacobStephen
Copy link
Contributor

@JoelJacobStephen JoelJacobStephen commented May 7, 2024

Ticket

Closes HFE-514

Description

This PR focuses on improving error handling and user actions in the admin dashboard. Recurring errors returned from the backend are stored, and are paired with appropriate error messages to improve error handling in the dashboard. The action bar in the users page is made to be more dynamic where buttons appear only when the action is relevant based on the selection made by the user

Example: Make Admin button is not shown when selected users are all admins

Objectives

  • A better system to handle errors by recording the different types of errors returned from the backend.
  • Assign appropriate error messages to the errors recorded.
  • Implement a dynamic action bar in the users page which dynamically reveals and hides action buttons based on relevancy.

Recording

Screen.Recording.2024-05-07.at.10.49.43.AM.mov

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@JoelJacobStephen JoelJacobStephen force-pushed the refactor/dashboard-improvements branch from 0398f7d to 506245d Compare May 13, 2024 04:15
@JoelJacobStephen JoelJacobStephen force-pushed the refactor/dashboard-improvements branch from 506245d to d926415 Compare May 15, 2024 13:29
@JoelJacobStephen JoelJacobStephen changed the base branch from release/2024.3.3 to patch May 15, 2024 13:30
@JoelJacobStephen JoelJacobStephen marked this pull request as ready for review May 15, 2024 13:30
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelJacobStephen is this PR focused only on some admin and user error management because there are other errors related to workspace and settings left.

@JoelJacobStephen
Copy link
Contributor Author

@nivedin The newly introduced error handling is only for common errors that are returned from the backend through graphql queries. It does not replace error messages created solely in the frontend (Example: There are error messages that are created in the frontend by only checking if the graphql query has been successful or not without checking the specific error message returned in the graphql response). I will slowly be moving to this style of error handling moving forward in the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants