Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syncing light states to deCONZ groups #117588

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented May 16, 2024

Breaking change

Proposed change

Change to take all lights states into consideration and only populate the available states.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

group: Group, lights: list[Light], override: bool = False
) -> None:
"""Sync group color state with light."""
data = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that last brightness, last CT etc wins ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is true, but that hasn't changed from before (except it was part of the library) behaviour hasn't changed, the real change here is group.raw["action"] = cast(TypedGroupAction, data) where all data from all lights have been considered and then overriding any existing data in the group.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit bbfc245 into home-assistant:dev May 17, 2024
24 checks passed
tr4nt0r pushed a commit to tr4nt0r/ha-core that referenced this pull request May 17, 2024
@frenck frenck mentioned this pull request May 17, 2024
@Kane610 Kane610 deleted the deconz-improve_group_sync_of_light_states branch May 17, 2024 15:30
@Kane610
Copy link
Member Author

Kane610 commented May 17, 2024

Thanks @frenck @balloob 🎉

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deconz] dimmable light groups have no brightness attribute
3 participants