Exclude gold and platinum integrations from .coveragerc #117563

epenet · 2024-05-16T12:51:01Z

Proposed change

SSIA, based on https://developers.home-assistant.io/docs/integration_quality_scale_index/#gold- and home-assistant/developers.home-assistant#1194
Tests: Above average test coverage for all integration modules

Sample output

Integrations: 1264
Invalid integrations: 3

Found errors. Generating files canceled.

Integration luftdaten:
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file

Integration point:
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file

Integration tellduslive:
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file
* [ERROR] [COVERAGE] has quality scale gold and should not be present in .coveragerc file

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-05-16T12:51:52Z

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (tellduslive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tellduslive can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign tellduslive Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-05-16T12:51:52Z

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (point) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of point can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign point Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-05-16T12:51:53Z

Hey there @fabaff, @frenck, mind taking a look at this pull request as it has been labeled with an integration (luftdaten) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of luftdaten can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign luftdaten Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

.coveragerc

epenet · 2024-05-16T12:54:09Z

.coveragerc

-    homeassistant/components/point/__init__.py
-    homeassistant/components/point/alarm_control_panel.py
-    homeassistant/components/point/binary_sensor.py
-    homeassistant/components/point/sensor.py


point has very low coverage... should it still qualify as gold (grandfather rule) or should we move back to silver?
See home-assistant/home-assistant.io#8477

---------- coverage: platform linux, python 3.12.2-final-0 ----------- Name Stmts Miss Cover Missing ------------------------------------------------------------------------------------- homeassistant/components/point/__init__.py 173 112 35% 67-82, 88-119, 124-143, 150-158, 163-172, 182-189, 193, 197-227, 231, 235-237, 241, 246, 250, 254, 264-282, 286, 290-294, 298-299, 307, 312, 317, 322-326, 331, 336 homeassistant/components/point/alarm_control_panel.py 58 58 0% 3-117 homeassistant/components/point/binary_sensor.py 58 58 0% 3-130 homeassistant/components/point/config_flow.py 95 13 86% 89, 94, 112-123, 128, 183-190 homeassistant/components/point/const.py 8 0 100% homeassistant/components/point/sensor.py 28 28 0% 3-87 ------------------------------------------------------------------------------------- TOTAL 420 269 36%

Let's correct it.

Reverted following #117783

epenet · 2024-05-16T12:54:56Z

.coveragerc

-    homeassistant/components/tellduslive/__init__.py
-    homeassistant/components/tellduslive/binary_sensor.py
-    homeassistant/components/tellduslive/cover.py
-    homeassistant/components/tellduslive/entry.py
-    homeassistant/components/tellduslive/light.py
-    homeassistant/components/tellduslive/sensor.py
-    homeassistant/components/tellduslive/switch.py


tellduslive has very low coverage... should it still qualify as gold (grandfather rule) or should we move back to silver?
See home-assistant/home-assistant.io#8481

---------- coverage: platform linux, python 3.12.2-final-0 ----------- Name Stmts Miss Cover Missing ------------------------------------------------------------------------------------- homeassistant/components/tellduslive/__init__.py 115 80 30% 58-79, 84-99, 104-117, 122-132, 140-146, 150-151, 155, 160-172, 176-195, 201-213, 219, 223 homeassistant/components/tellduslive/binary_sensor.py 18 18 0% 3-43 homeassistant/components/tellduslive/config_flow.py 73 0 100% homeassistant/components/tellduslive/const.py 16 0 100% homeassistant/components/tellduslive/cover.py 29 29 0% 3-59 homeassistant/components/tellduslive/entry.py 68 68 0% 3-119 homeassistant/components/tellduslive/light.py 43 43 0% 3-80 homeassistant/components/tellduslive/sensor.py 66 66 0% 3-197 homeassistant/components/tellduslive/switch.py 25 25 0% 3-53 ------------------------------------------------------------------------------------- TOTAL 453 329 27%

Let's correct it.

Reverted following #117784

epenet · 2024-05-16T13:02:46Z

script/hassfest/coverage.py

@@ -19,6 +19,7 @@
    "recorder.py",
    "scene.py",
 )
+FORCE_COVERAGE = ("gold", "platinum")


If we add internal to the list, we have:

browser

downloader

folder_watcher

kitchen_sink

otp

ping

recorder

stream

time_date

zeroconf

frenck

Thanks, @epenet 👍

../Frenck

home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels May 16, 2024

epenet added integration: tellduslive integration: point integration: luftdaten labels May 16, 2024

home-assistant bot added the Quality Scale: gold label May 16, 2024

home-assistant bot assigned fabaff and frenck May 16, 2024

epenet commented May 16, 2024

View reviewed changes

epenet marked this pull request as ready for review May 16, 2024 12:55

epenet requested a review from a team as a code owner May 16, 2024 12:55

epenet commented May 16, 2024

View reviewed changes

This was referenced May 20, 2024

Downgrade point quality scale to silver #117783

Merged

Downgrade tellduslive quality scale to silver #117784

Merged

epenet added 2 commits May 20, 2024 09:24

Exclude gold and platinum integrations from .coveragerc

56ae438

Early continue

a6d95d2

epenet force-pushed the 20240516-1448 branch from dd22466 to 446add0 Compare May 20, 2024 09:25

Revert point and tellduslive

57f4314

epenet force-pushed the 20240516-1448 branch from 446add0 to 57f4314 Compare May 20, 2024 09:26

Fix rebase

667368e

epenet removed integration: tellduslive integration: point labels May 22, 2024

frenck self-requested a review May 23, 2024 09:11

frenck approved these changes May 24, 2024

View reviewed changes

frenck merged commit 6a10e89 into home-assistant:dev May 24, 2024
38 checks passed

epenet deleted the 20240516-1448 branch May 24, 2024 14:11

github-actions bot locked and limited conversation to collaborators May 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude gold and platinum integrations from .coveragerc #117563

Exclude gold and platinum integrations from .coveragerc #117563

epenet commented May 16, 2024 •

edited

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

epenet May 16, 2024 •

edited

frenck May 18, 2024

epenet May 20, 2024 •

edited

epenet May 16, 2024 •

edited

frenck May 18, 2024

epenet May 20, 2024 •

edited

epenet May 16, 2024

frenck left a comment

Exclude gold and platinum integrations from .coveragerc #117563

Exclude gold and platinum integrations from .coveragerc #117563

Conversation

epenet commented May 16, 2024 • edited

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

home-assistant bot commented May 16, 2024

epenet May 16, 2024 • edited

Choose a reason for hiding this comment

frenck May 18, 2024

Choose a reason for hiding this comment

epenet May 20, 2024 • edited

Choose a reason for hiding this comment

epenet May 16, 2024 • edited

Choose a reason for hiding this comment

frenck May 18, 2024

Choose a reason for hiding this comment

epenet May 20, 2024 • edited

Choose a reason for hiding this comment

epenet May 16, 2024

Choose a reason for hiding this comment

frenck left a comment

Choose a reason for hiding this comment

epenet commented May 16, 2024 •

edited

epenet May 16, 2024 •

edited

epenet May 20, 2024 •

edited

epenet May 16, 2024 •

edited

epenet May 20, 2024 •

edited