Disable remote debug button when there are no runnable presets #92032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
adamscott
added a commit
to adamscott/godot
that referenced
this pull request
May 17, 2024
adamscott
added a commit
to adamscott/godot
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91981
Instead of iterating over the platforms, I changed the code to iterate over the presets , and get the platform from there, while also checking that they are Runnable. So if there are no presets, nothing happens.
Also, once that's fixed, I found another bug, where the
Remote Debugbutton does not update when a Web preset is added, modified, or deleted. That was due to the fact that thepoll_exportmethod does not check the validity of the preset options anymore. So I brought that back inEditorExportPlatformWeb::poll_export()