Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI tweaks #92020

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lalitshankarchowdhury
Copy link
Contributor

  1. Fix default font antialiasing method: Change the default antialiasing method to LCD subpixel, as the majority of users are not on HiDPI screens: source.

  2. Fix create project dialog UI. Center some options to make the project creation dialog look more appealing.

Before

Screenshot 2024-05-16 201213

After

Screenshot 2024-05-16 204641

Fix default font antialiasing

Fix create project dialog UI
@Calinou
Copy link
Member

Calinou commented May 16, 2024

Fix default font antialiasing method: Change the default antialiasing method to LCD subpixel, as the majority of users are not on HiDPI screens: source.

Note that this can make text look bad on OLED displays, but since these are in the minority, it's probably fine. Ideally, we'd detect the font rendering style based on the OS settings, but querying this requires OS-specific code that is currently not present in Godot.

That said, I would definitely not enable LCD subpixel antialiasing on macOS, as macOS itself no longer offers it since macOS 10.15. HiDPI displays are also pretty common among macOS users these days.

@flaff
Copy link

flaff commented May 16, 2024

Personally I don't think aligning radio options block to the center makes sense. This looks very out of place IMHO.

Design libraries that I worked with usually have radios aligned to the left for LTR.
Example: Material design radio button

@lalitshankarchowdhury
Copy link
Contributor Author

lalitshankarchowdhury commented May 16, 2024

That said, I would definitely not enable LCD subpixel antialiasing on macOS, as macOS itself no longer offers it since macOS 10.15. HiDPI displays are also pretty common among macOS users these days.

@Calinou I understand the subpixel antialiasing is done by freetype itself, so it won't be a problem on macOS.

@lalitshankarchowdhury
Copy link
Contributor Author

lalitshankarchowdhury commented May 16, 2024

Personally I don't think aligning radio options block to the center makes sense. This looks very out of place IMHO.

Design libraries that I worked with usually have radios aligned to the left for LTR. Example: Material design radio button

@flaff So, this is to address the case where the Create New Project dialog is stretched horizontally:

image

In the case of no centering, both the renderer choice and version control chooser are left aligned, which leads to two questions:

  1. Should we limit the maximum size of the dialog?
  2. Should we center align both the renderer chooser and version control chooser to make it look appealing?

AFAIK, Material design demos do not consider the possibility of horizontal width being greater than vertical width, being generally designed for smartphones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants