Rename task_id to group_id because WorkerThreadPool.wait_for_group_task_completion returns a grouped task

[ra314]

Rename task_id to group_id to conform to the parameter name for WorkerThreadPool.wait_for_group_task_completion

[AThousandShips]

Please update the title to reflect what is being done

Also the c# code should be updated as well

I'm not sure about this though, the returned value is "group task ID" so it's more correct to call it a task id than a group id in my opinion, so if anything it should be group_task_id

[AThousandShips]

You used find/replace and replaced too much

[ra314]

I thought this should be renamed.

"group task with the given ID" == "group_task_id", no?

[AThousandShips]

No that's outside the scope of this, please restore, this is just for documentaiton

[AThousandShips]

Please update the C# too, using groupTaskId

[ra314]

Just to be sure are these the changes you're looking for? (worker_thread_pool.cpp)

	ClassDB::bind_method(D_METHOD("is_group_task_completed", "group_task_id"), &WorkerThreadPool::is_group_task_completed);
	ClassDB::bind_method(D_METHOD("get_group_processed_element_count", "group_task_id"), &WorkerThreadPool::get_group_processed_element_count);
	ClassDB::bind_method(D_METHOD("wait_for_group_task_completion", "group_task_id"), &WorkerThreadPool::wait_for_group_task_completion);

I couldn't find any csharp files with group_id, groupId or groupTaskId.

[AThousandShips]

No not at all, don't change these parts, just the documentation right here, this part:

		    long taskId = WorkerThreadPool.AddGroupTask(Callable.From<int>(ProcessEnemyAI), _enemies.Count);
		    // Other code...
		    WorkerThreadPool.WaitForGroupTaskCompletion(taskId);