Fix Editor navigation mesh baking UndoRedo #91966
Open
+90
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes UndoRedo when baking a navigation mesh in the Editor so users can get back to a previous navigation mesh state if desired.
Scony
reviewed
May 16, 2024
Comment on lines
+203
to
+204
| Ref<NavigationPolygon> navigation_mesh = node->get_navigation_polygon(); | ||
| if (navigation_mesh.is_null()) { |
There was a problem hiding this comment.
does this rename actually makes sense?
There was a problem hiding this comment.
Yes I do it all the time in other PRs to have as much code similarity between 2D and 3D as possible.
There will be a point where NavigationPolygon as a resource name will disappear because frankly, that name sucks soo much. It is a 2D navigation mesh, not a single polygon, and it constantly confuses users in documentation and discussions, because the "real" polygons are the polygons inside a navigation mesh.
Comment on lines
+224
to
+230
| Vector<Vector2> redo_vertices = navigation_mesh->get_vertices(); | ||
| Vector<Vector<int>> redo_polygon_indices; | ||
| int redo_polygon_count = navigation_mesh->get_polygon_count(); | ||
| redo_polygon_indices.resize(redo_polygon_count); | ||
| for (int i = 0; i < redo_polygon_count; i++) { | ||
| redo_polygon_indices.write[i] = navigation_mesh->get_polygon(i); | ||
| } |
There was a problem hiding this comment.
this block is the same for undo/redo indices/vertices so perhaps we can extract it to helper function to reduce duplication and increase readability a bit?
Comment on lines
+118
to
+124
| Vector<Vector3> redo_vertices = navigation_mesh->get_vertices(); | ||
| Vector<Vector<int>> redo_polygon_indices; | ||
| int redo_polygon_count = navigation_mesh->get_polygon_count(); | ||
| redo_polygon_indices.resize(redo_polygon_count); | ||
| for (int i = 0; i < redo_polygon_count; i++) { | ||
| redo_polygon_indices.write[i] = navigation_mesh->get_polygon(i); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
UndoRedowhen baking a navigation mesh in the Editor so users can get back to a previous navigation mesh state if desired.Along the way of all the navigation mesh baking related changes the UndoRedo was broken. The old implementation did entire full resource duplicates for the UndoRedo which also was not really something to go back to because it broke all the resource ref handles.
The sacrifice of bringing UndoRedo back for navigation mesh baking inside the editor is that the baking needs to happen again on the main thread. There are just too many unsolved issues and changes required to make UndoRedo work with an async process.