Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add Projectile Trajectory project to SciComPy #54839

Open
wants to merge 116 commits into
base: main
Choose a base branch
from
Open

feat(curriculum): add Projectile Trajectory project to SciComPy #54839

wants to merge 116 commits into from
+3,753 −0

Conversation

ilenia-magoni
Copy link
Contributor

Checklist:

Closes #XXXXX

Dario-DC and others added 30 commits March 21, 2024 10:38
@Dario-DC @ojeytonwilliams
chore(curriculum): put Python certification projects in separate fold…
4e37060 
…ers (freeCodeCamp#54004)
@Dario-DC
Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…
1ccf56a 
…nto reorder-python
@Dario-DC
Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…
74a3707 
…nto reorder-python
@ilenia-magoni
create new project
f453405
@ilenia-magoni
create new project
2cc17d3
@ilenia-magoni
instructions for first 4 steps
b0a271a
@ilenia-magoni
first 4 steps instuctions
0bd423b
@ilenia-magoni
firt test
f85cf4e
@ilenia-magoni
change dashed name
138d705
@ilenia-magoni
tests steps 1-5
9a91f47
@ilenia-magoni
step 6
40cfa9c
@ilenia-magoni
step 7
d16aaac
@ilenia-magoni
fix typo
1ef3373
@ilenia-magoni
refactor test in step 7
4bb796d
@ilenia-magoni
step 8
956f7cc
@ilenia-magoni
Note: MathJax?
512856b
@ilenia-magoni
up to step 10
1d0f2af
@ilenia-magoni
steps 10-11
05f0ad3
@ilenia-magoni
+
6934d4d
@ilenia-magoni
step 12
24a43ad
@ilenia-magoni
step 17
e806708
@ilenia-magoni
typos
01aacd9
@ilenia-magoni
fix: typo
e9bc101
@Dario-DC
Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…
fc77aa5 
…nto reorder-python
@ilenia-magoni
up to step 22
4c3f7e1
@ilenia-magoni
Merge branch 'reorder-python' of https://github.com/freeCodeCamp/free…
b818dac 
…CodeCamp into projectile-trajectory
@ilenia-magoni
step 22
78be837
@ilenia-magoni
create new project
b691a66
@ilenia-magoni
create new project
c4a3e55
@ilenia-magoni
instructions for first 4 steps
e0c0a24
fhsinchy
fhsinchy approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@fhsinchy fhsinchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the steps. Looks fine to me. I managed to pass all the steps. The text looks great too.

Dario-DC
Dario-DC reviewed May 23, 2024
View reviewed changes
client/i18n/locales/english/intro.json Outdated Show resolved Hide resolved
...hallenges/_meta/learn-encapsulation-by-building-a-projectile-trajectory-calculator/meta.json Outdated
"usesMultifileEditor": true,
"hasEditableBoundaries": true,
"dashedName": "learn-encapsulation-by-building-a-projectile-trajectory-calculator",
"order": 221,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to check the order.

@ilenia-magoni @zairahira
Apply suggestions from code review
3dcaf0c 
Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>
zairahira
zairahira reviewed May 23, 2024
View reviewed changes
Copy link
Member

@zairahira zairahira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed all the steps, the tests ran fine for all of them.
I have left a couple of comments, after that the project is ready to go from my end.

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/662f9f65c50bd21d05ffdee9.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/662fa453ec8033322b3ab2e3.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475bab40e5125c84b03337.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md Outdated Show resolved Hide resolved
ilenia-magoni
ilenia-magoni commented May 29, 2024
View reviewed changes
...ting-with-python/learn-encapsulation-by-building-a-projectile-trajectory-calculator/index.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be fleshed out, see #43289 (comment)

gikf
gikf reviewed May 30, 2024
View reviewed changes
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/65f569725359e10d345bc52a.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/65fd4bd84561a14d3e720061.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475d40dd42fb614f14fd03.md Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475e40f3891c645d50135e.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475d40dd42fb614f14fd03.md Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633bdc3ca38c068c3735984.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633bfcef57e1d70cc3142c6.md Show resolved Hide resolved
Dario-DC
Dario-DC reviewed Jun 5, 2024
View reviewed changes
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660fcf3e1b9bb056b2edb567.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660fcf3e1b9bb056b2edb567.md
---

# --description--

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to complete it anymore (I mean without causing pyodide to crash). Always related to #55037

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the print seems to be the only solution but it will remove a way for the camper to see the output

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66335223f3e2a31d62d84367.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633b4d3271d5b3aea1c1195.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475bab40e5125c84b03337.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475e40f3891c645d50135e.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633c06601c081735063b528.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633c06601c081735063b528.md Show resolved Hide resolved
@ilenia-magoni @Dario-DC
Apply suggestions from code review
7220bf2 
Co-authored-by: Dario-DC <105294544+Dario-DC@users.noreply.github.com>
Dario-DC
Dario-DC reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions for the last step.

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633c06601c081735063b528.md Outdated Show resolved Hide resolved
...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633c06601c081735063b528.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zairahira zairahira zairahira left review comments

@gikf gikf gikf left review comments

@Dario-DC Dario-DC Dario-DC requested changes

@fhsinchy fhsinchy fhsinchy approved these changes

@larymak larymak Awaiting requested review from larymak

Requested changes must be addressed to merge this pull request.

Assignees

@zairahira zairahira

Labels
new python course platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilenia-magoni @fhsinchy @zairahira @gikf @Dario-DC